Skip to content

Conversation

@omgitsads
Copy link
Member

Adds support the the underlying mcp-go ServerOptions so that hook functions can be attached to the server.

Copilot AI review requested due to automatic review settings April 11, 2025 08:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the server initialization to allow passing through additional server options so that hook functions can be attached to the server.

  • Adds a variadic parameter for extra server options.
  • Appends default options (resource capabilities and logging) before creating the MCP server.

Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@omgitsads omgitsads merged commit 3c18a34 into main Apr 11, 2025
16 checks passed
@omgitsads omgitsads deleted the add-server-opts branch April 11, 2025 08:52
nickytonline pushed a commit to nickytonline/github-mcp-http that referenced this pull request Oct 4, 2025
* Allow passing through server options

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants