rename handler_dir to handler_plugin_dir

Author: GrantBirki

lib/hooks/core/config_loader.rb

@@ -8,7 +8,6 @@ module Core
     # Loads and merges configuration from files and environment variables
     class ConfigLoader
       DEFAULT_CONFIG = {
-        handler_dir: "./handlers",  # For backward compatibility
         handler_plugin_dir: "./handlers",
         auth_plugin_dir: nil,
         log_level: "info",
@@ -31,7 +30,6 @@ class ConfigLoader
       # @return [Hash] Merged configuration
       def self.load(config_path: nil)
         config = DEFAULT_CONFIG.dup
-        default_handler_dir = config[:handler_dir]
 
         # Load from file if path provided
         if config_path.is_a?(String) && File.exist?(config_path)
@@ -47,19 +45,6 @@ def self.load(config_path: nil)
         # Convert string keys to symbols for consistency
         config = symbolize_keys(config)
 
-        # Support backward compatibility for handler_dir <-> handler_plugin_dir
-        # Check if values changed from default
-        if config[:handler_plugin_dir] != default_handler_dir && config[:handler_dir] == default_handler_dir
-          # Only handler_plugin_dir was changed, sync handler_dir
-          config[:handler_dir] = config[:handler_plugin_dir]
-        elsif config[:handler_dir] != default_handler_dir && config[:handler_plugin_dir] == default_handler_dir
-          # Only handler_dir was changed, sync handler_plugin_dir
-          config[:handler_plugin_dir] = config[:handler_dir]
-        elsif config[:handler_plugin_dir] != default_handler_dir && config[:handler_dir] != default_handler_dir
-          # Both changed, handler_plugin_dir takes precedence
-          config[:handler_dir] = config[:handler_plugin_dir]
-        end
-
         if config[:environment] == "production"
           config[:production] = true
         else
@@ -120,7 +105,6 @@ def self.load_env_config
         env_config = {}
 
         env_mappings = {
-          "HOOKS_HANDLER_DIR" => :handler_dir,  # For backward compatibility
           "HOOKS_HANDLER_PLUGIN_DIR" => :handler_plugin_dir,
           "HOOKS_AUTH_PLUGIN_DIR" => :auth_plugin_dir,
           "HOOKS_LOG_LEVEL" => :log_level,

spec/acceptance/config/hooks.yaml

@@ -1,5 +1,5 @@
 # Sample configuration for Hooks webhook server
-handler_dir: ./spec/acceptance/handlers
+handler_plugin_dir: ./spec/acceptance/handlers
 log_level: debug
 
 # Request handling

spec/integration/hooks_integration_spec.rb

@@ -12,7 +12,7 @@
   def app
     @app ||= Hooks.build(
       config: {
-        handler_dir: "./spec/integration/tmp/handlers",
+        handler_plugin_dir: "./spec/integration/tmp/handlers",
         log_level: "error", # Reduce noise in tests
         request_limit: 1048576,
         request_timeout: 15,

spec/unit/lib/hooks/app/auth/custom_auth_integration_spec.rb

@@ -103,16 +103,14 @@ def error!(message, code)
 
     expect(config[:auth_plugin_dir]).to eq("./custom/auth/plugins")
     expect(config[:handler_plugin_dir]).to eq("./custom/handlers")
-    expect(config[:handler_dir]).to eq("./custom/handlers") # backward compatibility
   end
 
-  it "maintains backward compatibility with handler_dir" do
-    # Test that old handler_dir configuration still works
+  it "uses handler_plugin_dir configuration" do
+    # Test that handler_plugin_dir configuration works
     config = Hooks::Core::ConfigLoader.load(config_path: {
-      handler_dir: "./legacy/handlers"
+      handler_plugin_dir: "./custom/handlers"
     })
 
-    expect(config[:handler_dir]).to eq("./legacy/handlers")
-    expect(config[:handler_plugin_dir]).to eq("./legacy/handlers")
+    expect(config[:handler_plugin_dir]).to eq("./custom/handlers")
   end
 end

spec/unit/lib/hooks/core/config_loader_spec.rb

@@ -7,7 +7,7 @@
         config = described_class.load
 
         expect(config).to include(
-          handler_dir: "./handlers",
+          handler_plugin_dir: "./handlers",
           log_level: "info",
           request_limit: 1_048_576,
           request_timeout: 30,
@@ -33,7 +33,7 @@
         expect(config[:log_level]).to eq("debug")
         expect(config[:environment]).to eq("test")
         expect(config[:production]).to be false # should be false when environment is test
-        expect(config[:handler_dir]).to eq("./handlers") # defaults should remain
+        expect(config[:handler_plugin_dir]).to eq("./handlers") # defaults should remain
       end
     end
 
@@ -69,7 +69,7 @@
           expect(config[:environment]).to eq("development")
           expect(config[:request_timeout]).to eq(60)
           expect(config[:production]).to be false
-          expect(config[:handler_dir]).to eq("./handlers") # defaults should remain
+          expect(config[:handler_plugin_dir]).to eq("./handlers") # defaults should remain
         end
       end
 
@@ -205,56 +205,6 @@
       end
     end
 
-    context "with handler directory backward compatibility" do
-      it "uses handler_plugin_dir when both are set" do
-        custom_config = {
-          handler_dir: "./old/handlers",
-          handler_plugin_dir: "./new/handlers"
-        }
-
-        config = described_class.load(config_path: custom_config)
-
-        expect(config[:handler_dir]).to eq("./new/handlers") # backward compatibility
-        expect(config[:handler_plugin_dir]).to eq("./new/handlers")
-      end
-
-      it "sets handler_plugin_dir from handler_dir for backward compatibility" do
-        custom_config = { handler_dir: "./legacy/handlers" }
-
-        config = described_class.load(config_path: custom_config)
-
-        expect(config[:handler_dir]).to eq("./legacy/handlers")
-        expect(config[:handler_plugin_dir]).to eq("./legacy/handlers")
-      end
-
-      it "sets handler_dir from handler_plugin_dir for backward compatibility" do
-        custom_config = { handler_plugin_dir: "./new/handlers" }
-
-        config = described_class.load(config_path: custom_config)
-
-        expect(config[:handler_dir]).to eq("./new/handlers") # backward compatibility
-        expect(config[:handler_plugin_dir]).to eq("./new/handlers")
-      end
-
-      it "supports old HOOKS_HANDLER_DIR environment variable" do
-        ENV["HOOKS_HANDLER_DIR"] = "/legacy/handlers"
-
-        config = described_class.load
-
-        expect(config[:handler_dir]).to eq("/legacy/handlers")
-        expect(config[:handler_plugin_dir]).to eq("/legacy/handlers")
-      end
-
-      it "supports new HOOKS_HANDLER_PLUGIN_DIR environment variable" do
-        ENV["HOOKS_HANDLER_PLUGIN_DIR"] = "/new/handlers"
-
-        config = described_class.load
-
-        expect(config[:handler_dir]).to eq("/new/handlers") # backward compatibility
-        expect(config[:handler_plugin_dir]).to eq("/new/handlers")
-      end
-    end
-
     context "with production environment detection" do
       it "sets production to true when environment is production" do
         config = described_class.load(config_path: { environment: "production" })