Skip to content

Conversation

@cassidoo
Copy link
Contributor

@cassidoo cassidoo commented Apr 17, 2025

This lets a user add a location to an event and creates a chip for the location in the schedule.

The contributing guide is updated, and this also removes the "View More" button on the schedule because they aren't needed.

The diff looks larger than it really is, Copilot added location stuff to some of the events already listed, and did some formatting! Look at the components/ folder more than anything.

Copilot AI review requested due to automatic review settings April 17, 2025 19:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Fix #243 by adding an optional location field to event markdown files and updating the UI to display a location chip instead of the redundant "View More" button. Additionally, the contributing guide has been updated to document the new location field.

  • Added an optional "location" frontmatter field in multiple event files.
  • Modified EventList and EventDetail components to display the location chip.
  • Updated CONTRIBUTING.md to include documentation for the location field.

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
content/events/2025-05-30-effection.md Added location field with value "Virtual".
content/events/2025-05-19-COSSA.md Updated event details with the new location field and revised event info.
content/events/2025-05-13-RustWeek.md Added location field with combined format ("Hybrid - Berlin & Virtual").
content/events/2025-05-09-convex.md Added location field with value "Virtual".
content/events/2025-05-07-PyTorch.md New event file added with a location field.
content/events/2025-05-06-Licensing-SBOMs.md Updated event details, including changes in user link and location field.
content/events/2025-05-06-Innersource-China.md Added location field with value "Virtual".
content/events/2025-05-01-Welcome.md Introduced a location field for a podcast event.
content/events/2025-05-01-OpenSearch.md Added location field with value "Amsterdam".
content/events/20205-05-07-PyTorch.md Removed an outdated/erroneously named file.
content/2023/events/green-software-foundation-meetup.md Added location field with new hybrid location details.
components/events-list/EventsList.jsx Removed the "View More" button and added rendering for the location chip.
components/event-detail/EventDetail.jsx Added conditional rendering for a location chip in event detail view.
components/chip/Chip.jsx Updated Chip component to include a data attribute for virtual locations.
CONTRIBUTING.md Documented the new optional "location" field.
Files not reviewed (2)
  • components/chip/chip.scss: Language not supported
  • components/events-list/events-list.scss: Language not supported
Comments suppressed due to low confidence (1)

content/events/20205-05-07-PyTorch.md:1

  • The file name 'content/events/20205-05-07-PyTorch.md' appears to contain a typo in the year (20205 instead of 2025). Please verify if this removal is intended or if the file should be renamed.
----

@cassidoo cassidoo requested a review from karasowles April 17, 2025 19:37
@karasowles karasowles merged commit dbfebc6 into github:main Apr 17, 2025
1 check passed
@karasowles
Copy link
Contributor

Looks Extremely Good To Me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants