-
Notifications
You must be signed in to change notification settings - Fork 48
Add language #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language #260
Conversation
- Added language field to event frontmatter - Updated issue template to include language field - Added language display in event detail and list views - Updated documentation in CONTRIBUTING.md
- Enhance schedule page layout with multi-column grid display - Add responsive grid with up to 4 columns on large screens - Improve card layout and spacing utilization - Show event descriptions in cards - Add prominent "Add your activity" button - Position button in page header - Update button text for clarity - Improve button visibility with white background - Improve visual hierarchy of event information - Reorganize event meta information - Add subtle hover effects on cards - Style date chips consistently - Add distinctive styling for spoken language chips - Add data-spoken-language attribute to identify language indicators - Style language chips with purple background (#9C27B0) - Add detection for language prefixes and common language names Files changed: - components/events-list/events-list.scss - components/events-list/EventsList.jsx - components/chip/chip.scss - components/chip/Chip.jsx - content/commons.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances the event management system by introducing support for event languages, updating UI components to display the new language field, and removing outdated documentation.
- Added a new "language" frontmatter property in several event markdown files
- Updated the event list and event detail components to render language information via the Chip component
- Updated documentation and issue templates to include the event language field
Reviewed Changes
Copilot reviewed 29 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| content/events/*.md | Added "language" key to specify the event’s primary language |
| components/events-list/EventsList.jsx | Updated layout to include language display and restructured meta information |
| components/event-detail/EventDetail.jsx | Rendered language information within the event details |
| components/chip/Chip.jsx | Extended Chip component to mark spoken language indicators with a new data attribute |
| README-old.md, README-next.md | Removed deprecated documentation |
| CONTRIBUTING.md, .github/ISSUE_TEMPLATE/add-to-calendar.yml | Updated event frontmatter specifications and submission templates |
Files not reviewed (6)
- components/button-link/button-link.scss: Language not supported
- components/chip/chip.scss: Language not supported
- components/date-time-chip/date-time-chip.scss: Language not supported
- components/event-detail/event-detail.scss: Language not supported
- components/events-list/events-list.scss: Language not supported
- content/commons.json: Language not supported
|
Ooh, how do you do that Copilot review? 🤩 |
Co-authored-by: Copilot <[email protected]>
|
@The-Best-Codes here's more about Copilot Code Review! https://docs.github.com/en/copilot/using-github-copilot/code-review/using-copilot-code-review |
This pull request introduces enhancements to the event management system, including new features, UI/UX improvements, and code cleanups. The most notable changes involve adding support for event languages, improving the design and interactivity of components, and removing outdated documentation.