Skip to content

Convert from Karma/Chai/Mocha to Vitest with Playwright browser mode #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgreif merged 5 commits into from
Oct 9, 2025
Merged

Convert from Karma/Chai/Mocha to Vitest with Playwright browser mode #41

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eeae67a
Initial plan
Copilot Oct 7, 2025
4736a6b
Convert from Karma/Chai/Mocha to Vitest with Playwright browser mode
Copilot Oct 7, 2025
4758c3b
Address PR feedback: simplify test setup and remove Node 22 from matrix
Copilot Oct 8, 2025
40ef593
Move WebSocket server code to separate file test/websocket-server.js
Copilot Oct 8, 2025
75fea16
Ignore vitest screenshots
dgreif Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,18 @@ permissions:
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [22, 24]
Copy link
Contributor

@dgreif dgreif Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this matrix. Just use 24.

Copy link
Contributor Author

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the matrix. Now using Node 24 only. Fixed in 67e5336

steps:
- uses: actions/checkout@v4
- name: Use Node.js
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: 22
node-version: ${{ matrix.node-version }}
cache: npm
- run: npm install
- run: npx playwright install chromium
- run: npm run build
- run: npm test
env:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
registry-url: https://registry.npmjs.org/
cache: npm
- run: npm ci
- run: npx playwright install chromium
- run: npm test
- run: npm version ${TAG_NAME} --git-tag-version=false
env:
Expand Down
35 changes: 0 additions & 35 deletions karma.config.cjs
View file
Open in desktop

This file was deleted.

Loading