[Do not merge] v19.x #127

arthurschreiber · 2024-11-07T22:39:12Z

Description

This pull request is to help us track backported changes.

Related Issue(s)

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Documentation was added or is not required

Deployment Notes

Signed-off-by: Arthur Schreiber <[email protected]>

…o release-19.0-github Signed-off-by: Arthur Schreiber <[email protected]>

…to release-19.0-github Signed-off-by: Arthur Schreiber <[email protected]>

…ation. Signed-off-by: Arthur Schreiber <[email protected]>

Signed-off-by: Vicent Marti <[email protected]>

…fic switching (vitessio#15701) Signed-off-by: Matt Lord <[email protected]>

…itessio#15347) Signed-off-by: Tim Vaillancourt <[email protected]>

…gate startup (vitessio#16655) Signed-off-by: Manan Gupta <[email protected]>

github-actions · 2024-12-20T01:30:43Z

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

Push additional commits to the associated branch.
Remove the stale label.
Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions · 2024-12-27T01:30:52Z

This PR was closed because it has been stale for 7 days with no activity.

…0-github Signed-off-by: Mohamed Hamza <[email protected]>

Signed-off-by: Arthur Schreiber <[email protected]>

Use ubuntu 22.04 for all action workflows on v19.

Pull in latest upstream v19 changes

[release-19.0] Implement temporal comparisons (vitessio#17826) (vitessio#17852)

…zed strings in row events for unit tests (vitessio#14903) Signed-off-by: Rohit Nayak <[email protected]>

Signed-off-by: Matt Lord <[email protected]>

) Signed-off-by: Matt Lord <[email protected]>

…tctldclient (vitessio#16920) (vitessio#17015) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…fic in vtctldclient (vitessio#16920) (vitessio#17015)" This reverts commit ecb4ae1.

…ableACLConfig is true (vitessio#17274) Signed-off-by: garfthoffman <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Mohamed Hamza <[email protected]>

Fail loading an ACL config if the provided file is empty and enforceT…

…itessio#18073) (#155) Signed-off-by: Arthur Schreiber <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Arthur Schreiber <[email protected]>

…o#18260) Signed-off-by: Arthur Schreiber <[email protected]>

Fix subquery merging regression introduced in vitessio#11379 (vitessio#18260)

Signed-off-by: Arthur Schreiber <[email protected]>

…thub [release-19.0-github] Improve `UNION` query merging

github-actions · 2025-06-27T01:32:03Z

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

Push additional commits to the associated branch.
Remove the stale label.
Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions · 2025-07-05T01:31:36Z

This PR was closed because it has been stale for 7 days with no activity.

Signed-off-by: David Piegza <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: meiji163 <[email protected]>

Signed-off-by: meiji163 <[email protected]>

sqlparser: Remove unneeded escaping (vitessio#16255)

Signed-off-by: David Piegza <[email protected]>

…thub Set parsed comments in operator for subqueries (vitessio#18369)

Copilot

Pull Request Overview

This is a backport pull request for tracking changes that need to be applied to the v19.x branch of Vitess. The PR includes various fixes, improvements, and test updates across multiple components including vstreamer, throttling, logging, CI/CD configuration, and test frameworks.

Updates CI templates to use Ubuntu 22.04 instead of 24.04 and adds repository owner checks for self-hosted runners
Removes deprecated log.Flush() calls and unused timer functionality from vstreamer and vreplication
Introduces new test framework for vstreamer event validation and improves test coverage

Reviewed Changes

Copilot reviewed 187 out of 188 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/rowlog/rowlog.go	Removes deprecated log.Flush() call
test/templates/*.tpl	Updates CI runner configurations and adds repository ownership checks
go/vt/wrangler/*_test.go	Fixes regex escaping in test expectations
go/vt/vttablet/tabletserver/vstreamer/*	Major refactoring with new test framework and throttling improvements
go/vt/vttablet/tabletserver/throttle/*	Enhanced throttling error detection and test coverage
go/vt/vttablet/tabletserver/tabletenv/*	Updated logging format to use structured JSON output
go/vt/vttablet/tabletmanager/vreplication/*	Improved throttling metrics and lag calculation
go/vt/vtgate/*	Enhanced gateway functionality and buffering logic

Copilot · 2025-08-01T12:13:34Z

go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go

@@ -26,6 +26,8 @@ import (
 	"testing"
 	"time"

+	"github.com/prometheus/common/version"
+


The import of 'github.com/prometheus/common/version' appears to be unused in this file. Consider removing it unless it's used elsewhere in the code that wasn't shown in the diff.

Suggested change

Copilot · 2025-08-01T12:13:35Z

go/vt/vttablet/tabletserver/vstreamer/vstreamer_test.go

@@ -1721,6 +1587,9 @@ func TestBestEffortNameInFieldEvent(t *testing.T) {

 // test that vstreamer ignores tables created by OnlineDDL
 func TestInternalTables(t *testing.T) {
+	if version.GoOS == "darwin" {


Using 'version.GoOS' from prometheus package instead of the standard 'runtime.GOOS' is unconventional. Consider using 'runtime.GOOS' for OS detection as it's the standard Go approach.

Suggested change

if version.GoOS == "darwin" {

if runtime.GOOS == "darwin" {

Copilot · 2025-08-01T12:13:35Z

go/vt/vttablet/tabletserver/vstreamer/helper_event_test.go

+
+// Run() runs the test. It first initializes the test, then runs the queries and validates the events.
+func (ts *TestSpec) Run() {
+	require.NoError(ts.t, engine.se.Reload(context.Background()))


The test framework assumes global variables 'engine' exist. Consider passing these dependencies explicitly to improve testability and reduce coupling to global state.

Copilot · 2025-08-01T12:13:36Z

go/vt/vttablet/tabletserver/vstreamer/helper_event_test.go

+// Close() should be called (via defer) at the end of the test to clean up the tables created in the test.
+func (ts *TestSpec) Close() {
+	dropStatement := fmt.Sprintf("drop tables %s", strings.Join(ts.schema.TableNames(), ", "))
+	execStatement(ts.t, dropStatement)


[nitpick] The 'execStatement' function is called but not defined in this file. Consider adding error handling or documentation about where this function is defined to improve code clarity.

arthurschreiber and others added 9 commits October 15, 2024 14:29

Expose the --tablet_types_to_wait flag in vtcombo.

ce7168c

Signed-off-by: Arthur Schreiber <[email protected]>

Merge branch 'release-19.0' of https://github.com/vitessio/vitess int…

1cc01fc

…o release-19.0-github Signed-off-by: Arthur Schreiber <[email protected]>

Merge branch 'release-19.0' of https://github.com/vitessio/vitess int…

c6a5de0

…o release-19.0-github Signed-off-by: Arthur Schreiber <[email protected]>

Merge branch 'release-19.0' of https://github.com/github/vitess-gh in…

2b6d792

…to release-19.0-github Signed-off-by: Arthur Schreiber <[email protected]>

Only run on larger runners when running inside the vitessio organiz…

4bbc8bf

…ation. Signed-off-by: Arthur Schreiber <[email protected]>

logstats: do not allocate memory while logging (vitessio#15539)

2468076

Signed-off-by: Vicent Marti <[email protected]>

VReplication: Improve query buffering behavior during MoveTables traf…

381cf4d

…fic switching (vitessio#15701) Signed-off-by: Matt Lord <[email protected]>

Filter by keyspace earlier in tabletgateways WaitForTablets(...) (v…

24e0e37

…itessio#15347) Signed-off-by: Tim Vaillancourt <[email protected]>

Fix race condition that prevents queries from being buffered after vt…

341c62c

…gate startup (vitessio#16655) Signed-off-by: Manan Gupta <[email protected]>

github-actions bot added the Stale label Dec 20, 2024

github-actions bot closed this Dec 27, 2024

Merge branch 'release-19.0' into release-19.0-github

9b1f5c0

arthurschreiber reopened this Jan 23, 2025

github-actions bot removed the Stale label Jan 24, 2025

mhamza15 and others added 14 commits February 3, 2025 15:08

Merge remote-tracking branch 'upstream/release-19.0' into release-19.…

84429c0

…0-github Signed-off-by: Mohamed Hamza <[email protected]>

Run all workflows on ubuntu-24.04.

7812a28

Signed-off-by: Arthur Schreiber <[email protected]>

Switch back to ubuntu-22.04.

5275e69

Signed-off-by: Arthur Schreiber <[email protected]>

Regenerate files.

7ef1bdd

Signed-off-by: Arthur Schreiber <[email protected]>

Merge pull request #142 from github/arthur/use-ubuntu-24.04

d6a0cce

Use ubuntu 22.04 for all action workflows on v19.

Merge pull request #141 from github/release-19.0

1f282fb

Pull in latest upstream v19 changes

Merge pull request #143 from github/release-19.0

a0d4776

[release-19.0] Implement temporal comparisons (vitessio#17826) (vitessio#17852)

VStreamer Unit Tests: framework to remove the need to specify seriali…

cf6878d

…zed strings in row events for unit tests (vitessio#14903) Signed-off-by: Rohit Nayak <[email protected]>

VReplication: Add throttler stats (vitessio#15221)

61ef712

Signed-off-by: Matt Lord <[email protected]>

VReplication: Estimate lag when workflow fully throttled (vitessio#16577

6bd4970

) Signed-off-by: Matt Lord <[email protected]>

go mod tidy

b92a072

[release-21.0] VReplication: Support reversing read-only traffic in v…

ecb4ae1

…tctldclient (vitessio#16920) (vitessio#17015) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

Revert "[release-21.0] VReplication: Support reversing read-only traf…

3c768db

…fic in vtctldclient (vitessio#16920) (vitessio#17015)" This reverts commit ecb4ae1.

Fail loading an ACL config if the provided file is empty and enforceT…

55f229d

…ableACLConfig is true (vitessio#17274) Signed-off-by: garfthoffman <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Mohamed Hamza <[email protected]>

arthurschreiber and others added 6 commits April 7, 2025 18:59

Merge pull request #151 from github/mhamza/backport-empty-acl-fix

fea1028

Fail loading an ACL config if the provided file is empty and enforceT…

Properly handle grpc dial errors in the throttler metric aggregation (v…

0cb1030

…itessio#18073) (#155) Signed-off-by: Arthur Schreiber <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Arthur Schreiber <[email protected]>

Fix subquery merging regression introduced in vitessio#11379 (vitessi…

ca43c11

…o#18260) Signed-off-by: Arthur Schreiber <[email protected]>

Merge pull request #156 from github/backport-18260-to-release-19.0

498a466

Fix subquery merging regression introduced in vitessio#11379 (vitessio#18260)

Improve UNION query merging (vitessio#18289)

b114204

Signed-off-by: Arthur Schreiber <[email protected]>

Merge pull request #163 from github/backport-18289-to-release-19.0-gi…

3e8aa8f

…thub [release-19.0-github] Improve `UNION` query merging

github-actions bot added the Stale label Jun 27, 2025

github-actions bot closed this Jul 5, 2025

davidpiegza and others added 3 commits July 16, 2025 13:47

Set parsed comments in operator for subqueries (vitessio#18369)

7673484

Signed-off-by: David Piegza <[email protected]>

sqlparser: Remove unneeded escaping (vitessio#16255)

a919b4d

Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: meiji163 <[email protected]>

fix escape in testPlayerCopyVarcharPKCaseInsensitive

6a99578

Signed-off-by: meiji163 <[email protected]>

arthurschreiber reopened this Jul 23, 2025

Merge pull request #172 from github/backport-16255

408d1e6

sqlparser: Remove unneeded escaping (vitessio#16255)

github-actions bot removed the Stale label Jul 24, 2025

davidpiegza and others added 3 commits July 31, 2025 08:01

Update tests in select_cases.json

90f834e

Signed-off-by: David Piegza <[email protected]>

Update query in test case in select_cases.json

e8b6411

Signed-off-by: David Piegza <[email protected]>

Merge pull request #170 from github/backport-18369-to-release-19.0-gi…

e3188d8

…thub Set parsed comments in operator for subqueries (vitessio#18369)

Copilot AI review requested due to automatic review settings August 1, 2025 12:12

Copilot AI reviewed Aug 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Do not merge] v19.x #127

[Do not merge] v19.x #127

Uh oh!

arthurschreiber commented Nov 7, 2024

Uh oh!

github-actions bot commented Dec 20, 2024

Uh oh!

github-actions bot commented Dec 27, 2024

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Copilot AI Aug 1, 2025

Uh oh!

Uh oh!

[Do not merge] v19.x #127

Are you sure you want to change the base?

[Do not merge] v19.x #127

Uh oh!

Conversation

arthurschreiber commented Nov 7, 2024

Description

Related Issue(s)

Checklist

Deployment Notes

Uh oh!

github-actions bot commented Dec 20, 2024

Uh oh!

github-actions bot commented Dec 27, 2024

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!