Backport fix reshard cancel

[arthurschreiber]

Description

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[Copilot]

Pull Request Overview

This pull request backports a fix related to the reshard cancel functionality. It introduces a new flag to preserve partially copied data during a reshard operation and updates the server’s workflow to use the appropriate target cleanup method.

• Introduces the "keep-data" flag on the cancel command.
• Replaces the call to dropTargetShards with removeTargetTables in the workflow server.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
go/cmd/vtctldclient/command/vreplication/reshard/reshard.go	Adds a new flag to the cancel command for retaining partial table data
go/vt/vtctl/workflow/server.go	Changes the target cleanup method to remove target tables

Comments suppressed due to low confidence (2)

go/cmd/vtctldclient/command/vreplication/reshard/reshard.go:62

• Verify that the new 'keep-data' flag is fully integrated with the cancel command’s logic and that its behavior is documented in related user help or docs to avoid confusion.

cancel.Flags().BoolVar(&common.CancelOptions.KeepData, "keep-data", false, "Keep the partially copied table data from the Reshard workflow in the target shards.")

go/vt/vtctl/workflow/server.go:2526

• Confirm that replacing 'dropTargetShards' with 'removeTargetTables' correctly reflects the intended behavior for cleaning up target artifacts, ensuring that any dependencies on the old method are updated accordingly.

if err := sw.removeTargetTables(ctx); err != nil {

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR was closed because it has been stale for 7 days with no activity.