Fail loading an ACL config if the provided file is empty and enforceT… #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableACLConfig is true (vitessio#17274) Signed-off-by: garfthoffman <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Mohamed Hamza <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that loading an ACL configuration fails when the provided file is empty, preventing further processing on an invalid config.
- Added a check in tableacl.go to detect empty configuration data and return an error.
- Added a new test, TestInitWithEmptyConfig, in tableacl_test.go to validate that an empty file triggers the expected error.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/vt/tableacl/tableacl.go | Inserts a block to check for empty configuration file content and returns an error if empty. |
| go/vt/tableacl/tableacl_test.go | Introduces a test to ensure the system fails initialization when an empty config file is provided. |
Comments suppressed due to low confidence (1)
go/vt/tableacl/tableacl_test.go:88
- Consider verifying that the error message contains the expected text 'tableACL config file is empty' to ensure that the error is specifically raised due to the empty file.
require.Error(t, err)
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ableACLConfig is true (vitessio#17274)
Backports vitessio#17274
Closes https://github.com/github/vitess/issues/1338