sqlparser: Remove unneeded escaping (#16255) #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport vitessio#16255 to our release-19.0-github branch. This is necessary because the quote escaping can cause incorrect marshaling of json column in MarshalSQLTo.
For example
{"field": "[{\"k1":\"v1\"},{\"k2\":\"v2\"}]"
should be marshaled asJSON_OBJECT(_utf8mb4'field', _utf8mb4'[{"k1":"v1"},{":k2":"v2"}]')
. Instead it was marshaled asJSON_OBJECT(_utf8mb4'field', _utf8mb4'[{\\\"k1\\\":\\\"v1\\\"},{\\\":k2\\\":\\\"v2\\\"}]')
We encountered this in a MoveTables operation, where the VDiff found a mismatching row with extra escaped quotes in the json field.
Related Issue(s)
Checklist
Deployment Notes