sqlparser: Remove unneeded escaping (#16255) #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirkjan Bussink <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary escaping of double quotes in SQL string literals throughout the Vitess codebase. The change is part of the sqlparser improvements that standardize how string literals are formatted - specifically, since Vitess generates single-quoted strings, double quotes don't need to be escaped.
Key changes:
- Updated SQL string encoding to avoid escaping double quotes in single-quoted strings
- Modified test expectations across multiple test files to reflect the new formatting
- Updated parser test cases to match the new string literal output format
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go/vt/wrangler/*.go | Updated test expectations for vreplication query patterns to use unescaped double quotes |
| go/vt/vttablet/tabletmanager/vreplication/*.go | Updated test patterns for copy state and vreplication queries |
| go/vt/vtgate/planbuilder/testdata/select_cases.json | Updated test expectations for JSON function queries |
| go/vt/sqlparser/testdata/select_cases.txt | Updated parser test cases for string literals |
| go/vt/sqlparser/parse_test.go | Updated parser test expectations and added new test cases |
| go/vt/sqlparser/ast_format.go | Minor formatting fix for index options |
| go/sqltypes/value.go | Core change to SQL encoding logic to avoid escaping double quotes |
| go/sqltypes/value_test.go | Updated encoding test expectations |
|
On https://github.com/github/vitess-gh/actions/runs/16810268126?pr=175 you can see 3 failures, which I believe are caused by additional tests that have been added since v19 which still test for the (wrong) double escaping. Should be easy to fix those test cases. |
Signed-off-by: Mohamed Hamza <[email protected]>
arthurschreiber
approved these changes
Aug 7, 2025
|
Flaky test: vitessio#17434 |
Signed-off-by: Mohamed Hamza <[email protected]>
Signed-off-by: Mohamed Hamza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of vitessio#16255
Description
Related Issue(s)
Checklist
Deployment Notes