Skip to content

compare-perf: Show evaluation and iteration counts in table #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 2 commits into from
Nov 14, 2024
Merged

compare-perf: Show evaluation and iteration counts in table #3808

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b1eb20
Show evaluation and iteration counts in table
asgerf Nov 13, 2024
be52ca5
Merge branch 'hackathon/compare-perf' into asgerf/highlevel-stats
asgerf Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ interface OptionalValue {
}

interface PredicateInfo extends OptionalValue {
evaluationCount: number;
iterationCount: number;
pipelines: Record<string, PipelineSummary>;
}

Expand All @@ -48,6 +50,8 @@ class ComparisonDataset {
const index = nameToIndex.get(name);
if (index == null) {
return {
evaluationCount: 0,
iterationCount: 0,
tuples: 0,
absentReason: AbsentReason.NotSeen,
pipelines: {},
Expand All @@ -63,6 +67,8 @@ class ComparisonDataset {
}
}
return {
evaluationCount: data.evaluationCounts[index],
iterationCount: data.iterationCounts[index],
tuples: tupleCost,
absentReason,
pipelines: data.pipelineSummaryList[index],
Expand Down Expand Up @@ -184,6 +190,9 @@ interface PipelineStepProps {
step: string;
}

/**
* Row with details of a pipeline step, or one of the high-level stats appearing above the pipelines (evaluation/iteration counts).
*/
function PipelineStep(props: PipelineStepProps) {
let { before, after, step } = props;
if (before != null && before < 0) {
Expand All @@ -204,6 +213,46 @@ function PipelineStep(props: PipelineStepProps) {
);
}

interface HighLevelStatsProps {
before: PredicateInfo;
after: PredicateInfo;
}

function HighLevelStats(props: HighLevelStatsProps) {
const { before, after } = props;
const hasBefore = before.absentReason !== AbsentReason.NotSeen;
const hasAfter = after.absentReason !== AbsentReason.NotSeen;
const showEvaluationCount =
before.evaluationCount > 1 || after.evaluationCount > 1;
return (
<>
<tr>
<ChevronCell></ChevronCell>
<NumberHeader>{hasBefore ? "Before" : ""}</NumberHeader>
<NumberHeader>{hasAfter ? "After" : ""}</NumberHeader>
<NumberHeader>{hasBefore && hasAfter ? "Delta" : ""}</NumberHeader>
<NameHeader>Stats</NameHeader>
</tr>
{showEvaluationCount && (
<PipelineStep
before={before.evaluationCount || undefined}
after={after.evaluationCount || undefined}
step="Number of evaluations"
/>
)}
<PipelineStep
before={before.iterationCount / before.evaluationCount || undefined}
after={after.iterationCount / after.evaluationCount || undefined}
step={
showEvaluationCount
? "Number of iterations per evaluation"
: "Number of iterations"
}
/>
</>
);
}

function Chevron({ expanded }: { expanded: boolean }) {
return <Codicon name={expanded ? "chevron-down" : "chevron-right"} />;
}
Expand Down Expand Up @@ -350,6 +399,7 @@ export function ComparePerformance(_: Record<string, never>) {
</PredicateTR>
{expandedPredicates.has(row.name) && (
<>
<HighLevelStats before={row.before} after={row.after} />
{collatePipelines(
row.before.pipelines,
row.after.pipelines,
Expand Down
Loading