PoC: compare-performance of external logs #3817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
reviewed
Nov 14, 2024
| const tasksDir = join(dir, "tasks"); | ||
| await ensureDir(tasksDir); | ||
| // XXX hardcoded path | ||
| const dca = "/Users/esbena/Documents/codeql-dca/dca"; |
Contributor
There was a problem hiding this comment.
Seems like this won't work for anyone else. Is there an easy way around this?
Contributor
Author
There was a problem hiding this comment.
good catch. I forgot about that hardcoding! Let me see what can be done.
Contributor
Author
There was a problem hiding this comment.
you now need "codeql-dca.dir": "/Users/esbena/Documents/codeql-dca" in settings.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the command
codeQL.compare-performance.downloadExternalLogsstory.If
esbena/auto/esbena/more-downloads/230f947/1731498635271is entered as the experiment in the prompt for theCodeQL: Download External Logs for Performance Comparisoncommand, then the remote logs will be downloaded, processed, and used in the comparison view.Also turns the jsonl parser into a streaming parser with better logging