Skip to content

Compare-perf: Check for nullness of 'data' in a separate component #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 2 commits into from
Nov 15, 2024
Merged

Compare-perf: Check for nullness of 'data' in a separate component #3818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38976e9
Check for nullness of 'data' in a separate component
asgerf Nov 14, 2024
60216f9
Simplify datasets assignment
asgerf Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,14 +344,23 @@ export function ComparePerformance(_: Record<string, never>) {
[setData],
);

const datasets = useMemo(
() =>
data == null
? undefined
: {
from: new ComparisonDataset(data.from),
to: new ComparisonDataset(data.to),
},
if (!data) {
return <div>Loading performance comparison...</div>;
}

return <ComparePerformanceWithData data={data} />;
}

function ComparePerformanceWithData(props: {
data: SetPerformanceComparisonQueries;
}) {
const { data } = props;

const { from, to } = useMemo(
() => ({
from: new ComparisonDataset(data.from),
to: new ComparisonDataset(data.to),
}),
[data],
);

Expand All @@ -365,12 +374,6 @@ export function ComparePerformance(_: Record<string, never>) {

const [metric, setMetric] = useState<Metric>(metrics.tuples);

if (!datasets) {
return <div>Loading performance comparison...</div>;
}

const { from, to } = datasets;

const nameSet = new Set(from.data.names);
for (const name of to.data.names) {
nameSet.add(name);
Expand Down
Loading