compare-perf: Add support for selecting a single run as input #3821
Conversation
tausbn
force-pushed
the
tausbn/compare-perf-add-single-run-view-option
branch
from
8b2f378 to
98910a4
Compare
A very hacky implementation that simply instantiates an empty `PerformanceOverviewScanner` as the "from" column (i.e. with all values empty). To see it in action, select a single query run in the query history and pick "Compare Performance" from the context menu. Then select the "Single run" option when prompted.
tausbn
force-pushed
the
tausbn/compare-perf-add-single-run-view-option
branch
from
98910a4 to
73a865d
Compare
| <NumberHeader>{second != null && "After"}</NumberHeader> | ||
| <NumberHeader> | ||
| {first != null && second != null && "Delta"} | ||
| </NumberHeader> | ||
| {comparison && ( | ||
| <NumberHeader> | ||
| {first != null && | ||
| second != null && | ||
| (comparison ? "Delta" : "Value")} | ||
| </NumberHeader> | ||
| )} |
There was a problem hiding this comment.
Shouldn't we hide Delta and do comparison ? "After" : "Value" instead?
There was a problem hiding this comment.
I guess it amounts to the same if it's only done in the header, it just looks weird 🤔
There was a problem hiding this comment.
Actually the check on comparison is dead as it's inside another check for comparison
There was a problem hiding this comment.
Whoops! You're completely right. Brain was on autopilot.
|
Looks great! 🚢 |
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
The comment would be nice to fix but can be merged as is
|
works for me locally with hack to support external logs as well, that should be trial-by-fire enough |
|
Let's merge this before #3819 - I know the semantic conflicts that have to be addressed. |
|
I'll immediately do some cleanups to this once it is merged. I have the commits ready locally.. |
A very hacky implementation that simply instantiates an empty
PerformanceOverviewScanneras the "from" column (i.e. with all values empty). To see it in action, select a single query run in the query history and pick "Compare Performance" from the context menu. Then select the "Single run" option when prompted.Second commit takes care of simplifying the view when not in comparison mode.