Skip to content

Conversation

@koesie10
Copy link
Member

@koesie10 koesie10 commented Dec 6, 2024

This upgrades the version of code-server and alpine as used in the E2E tests. The E2E tests are currently expected to fail until we do a release due to the changes in #3853.

@koesie10 koesie10 force-pushed the koesie10/upgrade-e2e-versions branch 3 times, most recently from cbf936e to 54e531d Compare December 9, 2024 14:44
@koesie10 koesie10 marked this pull request as ready for review December 9, 2024 15:43
@koesie10 koesie10 requested a review from a team as a code owner December 9, 2024 15:43
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what prompted the upgrade?

@koesie10
Copy link
Member Author

Looks good, but what prompted the upgrade?

Nothing in particular, but I was updating the E2E tests as part of #3853 and noticed we were on a very old version of code-server (which means we'd also be on a very old version of VS Code). It would probably be a good idea to add a Dependabot config for updating the Dockerfile, so I'll do that in a follow-up PR.

@koesie10 koesie10 merged commit 7610de2 into main Dec 11, 2024
39 of 41 checks passed
@koesie10 koesie10 deleted the koesie10/upgrade-e2e-versions branch December 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants