Skip to content

Conversation

@aeisenberg
Copy link
Contributor

Reverts #3857

Let's see if we can get our e2e tests passing after this.

Copilot AI review requested due to automatic review settings December 11, 2024 20:36
@aeisenberg aeisenberg requested a review from a team as a code owner December 11, 2024 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • extensions/ql-vscode/package-lock.json: Language not supported
  • extensions/ql-vscode/package.json: Language not supported

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@angelapwen
Copy link
Contributor

Looks like the test is still failing now 😢

@aeisenberg
Copy link
Contributor Author

With the same error as before.

@charisk
Copy link
Contributor

charisk commented Dec 11, 2024

I believe the failures are expected (see note in #3853)

@aeisenberg
Copy link
Contributor Author

Ah...thanks. I missed that. Does this mean we need to create an extension release in order for the tests to start passing?

@aeisenberg aeisenberg closed this Dec 11, 2024
@charisk
Copy link
Contributor

charisk commented Dec 12, 2024

Ah...thanks. I missed that. Does this mean we need to create an extension release in order for the tests to start passing?

That's my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants