Fixed bug in foucault/ronchi view where it was always in AC mode #322
Conversation
|
Fixes #320 |
|
🚀 New build available for commit |
Thus does not work. If you put same message in top comment, it will autoclose :) |
|
Darn. There was a time when working with AI that it removed every other feature of the Ronchi/Foucualt except the show multiple ronchi diff images we were discussing. I told it to put that all back. I guess AI and I missed that part. |
|
In case you did not already figure it out. The auto collimation mode is rather simple you just apply the artificial null to the data. Just straight Ronchi test is done at ROC and thus should have SA from testing at ROC (the part the null removes) in it. So normally the artificial null is removed for standard ROnchi and Foucault. To do the DPAC part you just enable the null. At least that is the way I remember doing it. |
Co-authored-by: Julien Staub <[email protected]>
|
Yeah I understood this in the past. The wavefront doesn't show the SA as it's normal on a parabola but the ronchi and foucault need to. Anyway this patch fixes it. |
|
🚀 New build available for commit |
In the end it was a simple fix. The foucault/ronchi creation was moved into a static function so I passed a new argument to that function whether or not it should be in autocollimation mode.
I tested for the primary display and also the multi-ronchi view.