added blink compare to ronchi compare

[githubdoe]

New code to blink top two ronchi selected wave fronts

[github-actions]

🚀 New build available for commit 9dbdb6a
Download installer here

[gr5]

Sounds great. I hope to look at this tomorrow.

[githubdoe]

Deleted debug line in profile.cpp hide save button during blink. Just pushed.

[github-actions]

🚀 New build available for commit 2bf27ea
Download installer here

[gr5]

Well it works. It seems like there should be some code to stop the timer if someone closes the window though.

I tried closing the window while it was blinking and closed the ronchi window also and even deleted one of the wavefronts but no crash so I guess it's okay? I'd feel better if you detected the window closing.

Or does the window run a destructor which in turn runs the timer destructor which stops the timer?

[githubdoe]

Yes I think that all gets deleted when the window closes.

[githubdoe]

All objects created by a QDialog that have it as their parent are deleted when the dialog is deleted. Widgets that are in a layout have the layout as their parent and the layout eventually has has the dialog as it's parent. The timer has the dialog as it's parent. So it is deleted as well.

[gr5]

agreed. timer should be gone at the end of this if statement:

    // Connect the comparison trigger
    connect(compareBtn, &QPushButton::clicked, &previewDlg, [=, &previewDlg]() {
        // [=] copies individualRonchis and names so they stay
        // valid even after generateBatchRonchiImage() returns.
        if (individualRonchis.size() >= 2) {
            RonchiCompareDialog compDlg(individualRonchis[0], names[0],
                                        individualRonchis[1], names[1], &previewDlg);
            compDlg.exec();
        }
    });

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v18.1.3) reports: 1 concern(s)

• foucaultview.cpp:217:5: warning: [clang-analyzer-security.FloatLoopCounter]

  Variable 'currentMM' with floating point type 'double' should not be used as a loop counter

    217 |     for (double currentMM = stepSizeMM; currentMM <= mirrorRadiusMM; currentMM += stepSizeMM) {
        |     ^                                   ~~~~~~~~~                    ~~~~~~~~~
  foucaultview.cpp:217:5: note: Variable 'currentMM' with floating point type 'double' should not be used as a loop counter
    217 |     for (double currentMM = stepSizeMM; currentMM <= mirrorRadiusMM; currentMM += stepSizeMM) {
        |     ^                                   ~~~~~~~~~                    ~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

[github-actions]

Cpp-linter Review

Used clang-tidy v18.1.3

Have any feedback or feature suggestions? Share it here.

[github-actions]

clang-tidy diagnostic

foucaultview.cpp:217:5: warning: [clang-analyzer-security.FloatLoopCounter]

Variable 'currentMM' with floating point type 'double' should not be used as a loop counter

  217 |     for (double currentMM = stepSizeMM; currentMM <= mirrorRadiusMM; currentMM += stepSizeMM) {
      |     ^                                   ~~~~~~~~~                    ~~~~~~~~~
foucaultview.cpp:217:5: note: Variable 'currentMM' with floating point type 'double' should not be used as a loop counter
  217 |     for (double currentMM = stepSizeMM; currentMM <= mirrorRadiusMM; currentMM += stepSizeMM) {
      |     ^                                   ~~~~~~~~~                    ~~~~~~~~~

[github-actions]

🚀 New build available for commit eee6ba2
Download installer here

[gr5]

I merged pr 334. @atsju go ahead and close this one and open a new one based on dale's branch. I think that is what you recommend? I have to travel for the next 4 hours and don't have time to look at any of this until much later today.