Ensure safe-output jobs verify output type presence regardless of min constraint #2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update BuildSafeOutputType to always include contains() check - Remove special handling for min > 0 that skipped the check - Update all test expectations to verify contains check is present - Recompile all workflow lock files with updated conditions This ensures safe-output jobs only run when the agent actually produced outputs of that type, regardless of min constraint. The min constraint is enforced by the job itself via validation. Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
[WIP] Fix safe-output jobs running when workflow is cancelled
Ensure safe-output jobs verify output type presence regardless of min constraint
Oct 31, 2025
Copilot finished work on behalf of
pelikhan
October 31, 2025 19:52
pelikhan
approved these changes
Oct 31, 2025
pelikhan
merged commit 5c5318b
into
fix/safe-outputs-skip-on-cancel-9216d19286161389
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe-output jobs with
min > 0were skipping thecontains(needs.agent.outputs.output_types, 'type')check, causing them to run even when the agent produced no outputs of that type.Changes
BuildSafeOutputType(): Always includecontains()check in job condition, removing special case formin > 0collect_ndjson_output.cjssafe_outputs_min_condition_test.go,expressions_cancelled_test.go, andsafe_jobs_test.go.lock.ymlfiles with updated conditionsExample
Before (with
min: 1):After:
Jobs now only run when the agent actually produced the expected output type.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.