Skip to content

fix: prevent the app to open behind Windows tray #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SiriusCrain wants to merge 1 commit into from
Closed

fix: prevent the app to open behind Windows tray #2028

SiriusCrain wants to merge 1 commit into from

Conversation

@SiriusCrain
Copy link
Contributor

@SiriusCrain SiriusCrain commented May 27, 2025

Potential fix for #1048, will test on Windows 11 laptop later, in draft for now

@github-actions github-actions bot added the bug Something isn't working label May 27, 2025
SiriusCrain
SiriusCrain commented May 27, 2025
View reviewed changes
src/main/main.ts
log.initialize();

const browserWindowOpts = {
const browserWindowOpts: BrowserWindowConstructorOptions = {
Copy link
Contributor Author

@SiriusCrain SiriusCrain May 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI added type so we will not pass invalid props, also adds autosuggest on typing

@SiriusCrain SiriusCrain marked this pull request as ready for review May 27, 2025 11:55
@SiriusCrain
Copy link
Contributor Author

SiriusCrain commented May 27, 2025

Review it please, I will test in few hours, when will be near win laptop

@setchy
Copy link
Member

setchy commented May 27, 2025

Review it please, I will test in few hours, when will be near win laptop

I thought the fix for this issue is much further upstream with the maxmapper package window positioning algorithm - max-mapper/menubar#264

@SiriusCrain
Copy link
Contributor Author

SiriusCrain commented May 27, 2025

Review it please, I will test in few hours, when will be near win laptop

I thought the fix for this issue is much further upstream with the maxmapper package window positioning algorithm - max-mapper/menubar#264

Oh, I get it now, I misunderstood problem at first

@SiriusCrain
Copy link
Contributor Author

SiriusCrain commented May 27, 2025

Unfortunately it does not help

@SiriusCrain SiriusCrain reopened this May 27, 2025
@setchy
Copy link
Member

setchy commented May 27, 2025

Thanks for trying @SiriusCrain 🙏

@SiriusCrain
Copy link
Contributor Author

SiriusCrain commented May 27, 2025

Thanks for trying @SiriusCrain 🙏

Thanks, it is kinda helped, but was not closing window when click outside)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

@setchy setchy Awaiting requested review from setchy setchy is a code owner

Assignees

No one assigned

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SiriusCrain @setchy