Fixes unit tests runnings and improves eslint configuration #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzaytsev
force-pushed
the
chore/GLVSC-594_configure_unit_tests
branch
3 times, most recently
from
72cffdd to
aa8d138
Compare
d13
reviewed
Jul 22, 2024
nzaytsev
force-pushed
the
chore/GLVSC-594_configure_unit_tests
branch
from
57772bb to
739887e
Compare
nzaytsev
force-pushed
the
chore/GLVSC-594_configure_unit_tests
branch
2 times, most recently
from
dcddba8 to
9dd106c
Compare
- improves eslint config - allows store __tests__ subdirectories - lints warnings - Adds more tests for color - Adds restriction for using .only tests suites - Adds sample tests for iterable
- Merges webview eslint rules to main confix - Adds test coverage
nzaytsev
force-pushed
the
chore/GLVSC-594_configure_unit_tests
branch
from
9dd106c to
427ce89
Compare
|
Can we split this into an eslint change/upgrade (and take it further to ESLint 9 and the latest typescript-eslint) and then have the unit test work sit on top of that? |
Closed
|
Let's get this on top of #3585 |
|
closed in favor of #3590 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
allows store tests subdirectories
lints warnings
ignores trie tests
makes vscode-tests running with vscode/test-cli
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses