Skip to content

Adds onboarding feature on the home page GLVSC-613 #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Adds onboarding feature on the home page GLVSC-613 #3435

wants to merge 17 commits into from

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Jul 30, 2024 •
edited
Loading

Description

Shows progress tracker and onboarding items according to UsageTracker data

Screenshot 2024-08-05 at 18 34 15

Both action buttons as optional

Play icon is always a button that expects the href to be passed. Can run commands or open tabs

Info icon can have href property and title property. These properties are independent.
If the button has a href, then it can work as the play button. If the button has a title, it renders the tooltip on hover

Screenshot 2024-07-30 at 16 35 14

Onboarding items state is based on UsageTracker. Some items check if Views or webViews are shown, other checks if commands are executed, and there are 2 specific states:

  • connect with repo host is based on current connection state
  • codelens has its' own track key and it's tracked on the first codelens os shown

Info icons lead to corresponding youtube video part from the previous onboarding. Play buttons inspect corresponding app views.

Screen.Recording.2024-08-05.at.18.39.37.mov

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

d13
d13 reviewed Jul 30, 2024
View reviewed changes
d13
d13 reviewed Jul 30, 2024
View reviewed changes
d13
d13 reviewed Jul 30, 2024
View reviewed changes
d13
d13 reviewed Jul 31, 2024
View reviewed changes
@nzaytsev nzaytsev force-pushed the features/GLVSC-613-onboarding-on-the-home-page branch 2 times, most recently from 09caadc to 7a79aeb Compare August 5, 2024 11:33
@nzaytsev nzaytsev marked this pull request as ready for review August 5, 2024 11:42
nzaytsev
nzaytsev commented Aug 5, 2024
View reviewed changes
Copy link
Contributor Author

@nzaytsev nzaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions should be answered, maybe some info links and tooltips should be improved

@nzaytsev nzaytsev requested review from d13 and eamodio August 5, 2024 11:43
d13
d13 reviewed Aug 5, 2024
View reviewed changes
@nzaytsev nzaytsev requested a review from d13 August 6, 2024 04:41
@axosoft-ramint axosoft-ramint self-requested a review August 8, 2024 21:29
@d13 d13 force-pushed the features/GLVSC-613-onboarding-on-the-home-page branch from fa2a0ae to 54c638b Compare August 9, 2024 20:34
@nzaytsev nzaytsev force-pushed the features/GLVSC-613-onboarding-on-the-home-page branch 3 times, most recently from aea63d9 to 38fec06 Compare August 21, 2024 11:37
@nzaytsev nzaytsev linked an issue Sep 9, 2024 that may be closed by this pull request
Onboarding checklist in Home #3552
Closed
nzaytsev and others added 11 commits September 9, 2024 16:54
@nzaytsev
Adds onboading feature
d824e7f 
- add web-component app to the home page
- use UsageTracker as state provider



Updates changelog

Fix review notes
@nzaytsev
Improves UsageTracker:
485e1ed 
- Track commands
- Track blame hover
- Fix webview tracking: track view usage on webview is ready
- Track codelens
- Track repo host connection
@nzaytsev
test commit, may be rolled back
959fa65
@d13 @nzaytsev
Updates onboarding state
45824d8
@d13 @nzaytsev
Updates home onboarding ux
1c4caba
@d13 @nzaytsev
Fixes onboarding tooltip color
112507a
@nzaytsev
Fixes some issues
31bc267 
- untracked files should not activate play buttons
- codelens should be triggered on vscode start if the file is already opened
- editor features should not be available for untracked files
- toggle codelens should only enable and be available only when disabled
@d13 @nzaytsev
Fixes missing play tooltip
16926b3
@d13 @nzaytsev
Fixes active editor tracking
25ff37c
@nzaytsev
Adds disabled prop to onboarding
bd8969e
@nzaytsev
Fixes onReloaded state
52b73ae
@nzaytsev
Removes unused method
13e3531
@nzaytsev
Replaces toggle blame to enable blame
ac41a55
@nzaytsev
Fixes unnecessary expanding
40dc845 
- Stores isInitialized flag for the onboarding, changes it on integration connection change with timeout
- Makes the accordion component fully controlled
@nzaytsev
Adds mini progress
772f082
@nzaytsev
Improvements for pro features
0e88c63 
- add mini progress
- enable/disable pro items [commit graph, visual file history] on show/hide plus features
- group pro features (the parent item calls Restore pro features show
- add activate/reactivate trial item to the onboarding
- add upgrade to pro item
- open walkthrough pages by click on some items info button
- try change state of walkthrough steps
@nzaytsev
Fixes disabled item focus
83d64bc 
1
@nzaytsev nzaytsev force-pushed the features/GLVSC-613-onboarding-on-the-home-page branch from 38fec06 to 83d64bc Compare September 9, 2024 10:01
@d13
Copy link
Member

d13 commented Sep 9, 2024

Converting this back to draft since the scope of this is changing quite a lot

@d13 d13 marked this pull request as draft September 9, 2024 16:22
axosoft-ramint
axosoft-ramint reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: commented in the wrong PR, sorry!

@nzaytsev
Copy link
Contributor Author

nzaytsev commented Nov 4, 2024

looks like it's no longer needed

@nzaytsev nzaytsev closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axosoft-ramint axosoft-ramint axosoft-ramint left review comments

@eamodio eamodio Awaiting requested review from eamodio

@d13 d13 Awaiting requested review from d13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Onboarding checklist in Home

3 participants

@nzaytsev @d13 @axosoft-ramint