-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adds create branch split-dropdown button to the commit graph #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
d13
merged 8 commits into
main
from
features/GLVSC-636_add-a-create-branch-split-button-to-the-graph
Oct 2, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e0187e3
Truncates branch name inside the action button on the commit graph #3499
nzaytsev 8c95fae
Adds create branch button to the commit graph
nzaytsev 98ae938
Changes PopMenu for GlPopover
d13 7cf65e1
Removes graph icon customization from codicons
d13 8356c52
Removes current branch default for create branch command
d13 bd589a3
Simplifies create branch action on graph
d13 66a08e4
Fixes Command import
d13 1091131
Fixes command start & updates tooltip
eamodio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -304,6 +304,20 @@ button:not([disabled]), | |
.codicon[class*='codicon-graph-line'] { | ||
transform: translateY(1px); | ||
} | ||
.codicon-custom-git-branch-create { | ||
&:before { | ||
content: '\ea68'; | ||
} | ||
&:after { | ||
content: '\ea60'; | ||
position: absolute; | ||
right: 0; | ||
bottom: 0; | ||
font-size: 0.6em; | ||
line-height: normal; | ||
transform: translate(-50%, 0%); | ||
} | ||
} | ||
Comment on lines
+307
to
+320
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is fine for here, but a new GlIcon that we can use in other places would be nice. |
||
|
||
&__pill { | ||
.is-ahead & { | ||
|
@@ -345,6 +359,12 @@ button:not([disabled]), | |
overflow: hidden; | ||
} | ||
|
||
&__truncated { | ||
width: 100%; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
} | ||
|
||
&.is-ahead { | ||
background-color: var(--branch-status-ahead-background); | ||
|
||
|
@@ -966,6 +986,7 @@ gl-feature-gate gl-feature-badge { | |
&__header { | ||
flex: none; | ||
z-index: 101; | ||
// width: fit-content; | ||
position: relative; | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about this -- since it could impact a bunch of flows, so will need to be tested.