Skip to content

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Sep 2, 2024

Description

Resolves #2350

Supported places that can be formatted:

  • hover

Screenshot 2024-09-02 at 08 25 35

  • commit graph commit formatter

Screenshot 2024-09-02 at 08 26 03

Non-supported places:

  • line annotation (use :after pseudo element content that can only be a string)

Screenshot 2024-09-02 at 08 27 24

  • tree nodes (only string can be passed as the label of the tree node)

Screenshot 2024-09-02 at 08 27 41

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Sep 2, 2024 that may be closed by this pull request
@nzaytsev nzaytsev requested a review from eamodio September 2, 2024 01:28
@nzaytsev nzaytsev force-pushed the features/2350-add-monospace-formatting-in-commit-messages branch 2 times, most recently from fa3d389 to 9d96f28 Compare September 9, 2024 09:20
@nzaytsev nzaytsev changed the title Tries markdown commits formatting for all supported places Adds monospace formatting in commit messages Sep 9, 2024
@nzaytsev nzaytsev force-pushed the features/2350-add-monospace-formatting-in-commit-messages branch from 9d96f28 to 25a6cc5 Compare September 9, 2024 09:22
@nzaytsev nzaytsev marked this pull request as ready for review September 9, 2024 09:22
@nzaytsev nzaytsev self-assigned this Sep 9, 2024
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok to me - the only question would be whether we are ok pulling in markdown-it for this, if there is a more lightweight way to achieve it. in the graph. Thoughts @eamodio ?

CHANGELOG.md Outdated
### Added

- Adds a `gitlens.views.showCurrentBranchOnTop` setting to specify whether the current branch is shown at the top of the views — closes [#3520](https://github.com/gitkraken/vscode-gitlens/issues/3520)
- Adds monospace formatting in commit messages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include what issue it closes, and a link to the issue (see the entry in the line above this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@nzaytsev
Copy link
Contributor Author

@axosoft-ramint

the only question would be whether we are ok pulling in markdown-it for this, if there is a more lightweight way to achieve it. in the graph.

I'm pulling only ts lib as dev dependency. As far as I understand markdown-it is a part of vscode and can be used without additional pulling

Screenshot 2024-09-18 at 10 32 30

@nzaytsev nzaytsev force-pushed the features/2350-add-monospace-formatting-in-commit-messages branch from 25a6cc5 to 62c8635 Compare September 18, 2024 03:34
nzaytsev and others added 2 commits September 25, 2024 00:20
Moves markdown web component into shared
Moves markdown-related functions to a dedicated file
@eamodio eamodio force-pushed the features/2350-add-monospace-formatting-in-commit-messages branch from 62c8635 to 035a1cd Compare September 25, 2024 04:52
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied some changes to leverage existing components

@eamodio eamodio merged commit f0def4a into main Sep 25, 2024
3 checks passed
@eamodio eamodio deleted the features/2350-add-monospace-formatting-in-commit-messages branch October 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add monospace formatting in commit messages

3 participants