Adds a sidebar to the Commit Graph #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
force-pushed
the
feature/graph-sidebar
branch
2 times, most recently
from
8c80ee1 to
666a791
Compare
d13
reviewed
Sep 3, 2024
| timestamp: number; | ||
| }, | ||
| > extends GlElement { | ||
| @property({ type: String }) name!: string; |
There was a problem hiding this comment.
Let's add delegatesFocus this since the App itself doesn't need to be focusable:
static override shadowRootOptions: ShadowRootInit = {
...LitElement.shadowRootOptions,
delegatesFocus: true,
};
Comment on lines
+67
to
+76
| document.querySelectorAll('a').forEach(a => { | ||
| if (a.href === a.title) { | ||
| a.removeAttribute('title'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I wonder if we should just do this in GlElement? Though it could add up to a lot of DOM work.
There was a problem hiding this comment.
Ugh, I hate to need every component to do this, and vscode only does it once on load
There was a problem hiding this comment.
Wondering if we even need this in Shadow DOM
eamodio
force-pushed
the
feature/graph-sidebar
branch
from
610f8b6 to
dd295ec
Compare
Adds ipc & logging context for components
eamodio
force-pushed
the
feature/graph-sidebar
branch
from
dd295ec to
f9eb66e
Compare
d13
added
pending-release
axosoft-ramint
removed
the
pending-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.