-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adds a way to force push from the Graph #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a way to force push from the Graph #3507
Conversation
@d13 @eamodio @sergeibbb |
Let's wait on the sync action and focus on the push, pull and force-push. Sync will need some more thought on how we offer that, both on the Graph and throughout GitLens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we want to avoid using React as much as possible in GitLens.
For history, when the graph view was originally built, we didn't have a grasp on how to effectively use web components yet.
Our plan now is to invert how React is used today in the graph view. Instead of creating React wrappers for every web component used in the Graph, we plan to put a single web component wrapper around the graph's react component and focus on using web platform APIs for reactivity.
removed/hidden code associated with sync function, use only pull and push
Do you suggest moving the SyncButton component to lit now? |
962de6a
to
b105be2
Compare
f87b918
to
c6121ad
Compare
- add sync button and action - await for pull before run push - add split button dropdown
c6121ad
to
a587e13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just pushed an enhancement to the tooltip
Description
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses