Graduates Launchpad out of preview #3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking good, just a couple of questions/suggestions.
I'm also wondering how we want the indicator to work once this is live. Would it still show up, grab and summarize PRs in the hover, etc.?
Also, would it be weird that the hover says "connect an integration to get started" when really the user needs to upgrade to Pro first?
eamodio
force-pushed
the
feature/launchpad-exit-preview
branch
from
fec8923 to
9bcdbeb
Compare
- Adds a promotion for Launchpad - Allows access until promo ends Removes (disables) legacy "focus" editor
axosoft-ramint
force-pushed
the
feature/launchpad-exit-preview
branch
from
9bcdbeb to
fdd22f3
Compare
axosoft-ramint
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs finalized messaging and promo testing.