Skip to content

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Sep 16, 2024

Description

Changes path to TypeScript SDK in settings to nix style, because otherwise VS Code on MacOS fails with detecting the right TypeScript path

Testing notes

Expected result: your VS Code understands the nix-style path to TypeScript SDK and the typescript version is detected as 5.6.0-beta

Undesired result:

  • VS Code cannot understand the path, so it doesn't see the SDK in the project and switches to its ovn SDK, probably 5.5.4.
  • In this case it shows errors in some files. For example in pull.ts (see on the picture)

image

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb modified the milestone: 15.5-patch Sep 17, 2024
@sergeibbb sergeibbb self-assigned this Sep 17, 2024
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say here, other than that I tested the following in Windows 11 about a week ago and had no issues:

  • checkout this branch
  • build it, see no issues
  • open VS Code, and see no TS issues (checked several files)

@eamodio eamodio merged commit 0b6c975 into main Sep 18, 2024
2 checks passed
@axosoft-ramint axosoft-ramint added this to the 15.6 milestone Oct 2, 2024
@axosoft-ramint axosoft-ramint added pending-release Resolved but not yet released to the stable edition debt Technical debt labels Oct 2, 2024
@d13 d13 removed the pending-release Resolved but not yet released to the stable edition label Oct 14, 2024
@sergeibbb sergeibbb deleted the chore/nix-style-typescript-path-in-settings branch November 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants