Skip to content

Conversation

axosoft-ramint
Copy link
Contributor

@axosoft-ramint axosoft-ramint commented Sep 18, 2024

Also updates telemetry source to 'quick-wizard'

Closes #3576

Updates telemetry source to 'quick-wizard'
@eamodio
Copy link
Member

eamodio commented Sep 23, 2024

Hey @axosoft-ramint, while reviewing your PR, I'd suggest the following code changes:

👉 Title: Refactor quick command system for better modularity

While this only goes part of the way it starts paving the path to separate them more holistically

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@axosoft-ramint
Copy link
Contributor Author

@eamodio Committed the suggested changes after some testing to make sure nothing broke 👍🏼 thanks!

Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to check in with @trevor-polidore on the telemetry key changes

@axosoft-ramint
Copy link
Contributor Author

Please be sure to check in with @trevor-polidore on the telemetry key changes

Already got a 👍🏼 on these last week, and gave a heads-up today that they will be live in pre-release and in the next release.

@axosoft-ramint axosoft-ramint merged commit 7bf410b into main Sep 24, 2024
3 checks passed
@axosoft-ramint axosoft-ramint deleted the refactor/quick-wizard branch September 24, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix telemetry event for 'upgrade' actions taken from the promo banner in Launchpad

2 participants