Skip to content

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Sep 19, 2024

Description

Screenshot 2024-09-19 at 12 00 14

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Sep 19, 2024 that may be closed by this pull request
@nzaytsev nzaytsev force-pushed the features/3521-add-tooltip-to-the-badge-indicating-additional-gk-orgs branch from 33f5c50 to ff89bfe Compare September 19, 2024 03:25
@nzaytsev nzaytsev requested review from d13 and eamodio September 19, 2024 03:25
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nzaytsev Sorry, but intent here was to just wrap:

<span class="account__badge">+${this.organizationsCount - 1}</span>

in a <gl-tooltip> to say something like "X Organizations" or "You are part of X organizations"

@nzaytsev
Copy link
Contributor Author

@nzaytsev Sorry, but intent here was to just wrap:

<span class="account__badge">+${this.organizationsCount - 1}</span>

in a <gl-tooltip> to say something like "X Organizations" or "You are part of X organizations"

no problem, I'll revert redundant changes. It was just an experiment :)

@nzaytsev nzaytsev force-pushed the features/3521-add-tooltip-to-the-badge-indicating-additional-gk-orgs branch from ff89bfe to 42b9d0f Compare September 19, 2024 05:00
@nzaytsev nzaytsev requested a review from eamodio September 19, 2024 05:00
@justinrobots
Copy link
Collaborator

justinrobots commented Sep 20, 2024

@nzaytsev Minor UX feedback for this: since the label in this example is displaying +1, saying you are "part of 2 organizations" might cause some confusion. A user might think, "Why does the label say +1 but the tooltip mentions 2 organizations?"

I would expect the tooltip to describe the +1 case, and only list the other organizations that I am in that are not already displayed in the Account information. In this case, the tooltip could say:

You are in 1 other organization:
- n2 organization

Additionally, this tooltip currently assumes there will always be more than one org in the list, so "organizations" is always plural. If we change the message to ☝️ , then it will need to handle "organization" vs. "organizations".

Curious what you think @eamodio

@eamodio
Copy link
Member

eamodio commented Sep 21, 2024

Closing in favor of d3b4012 on the new Home view

image

@eamodio eamodio closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tooltip to the badge indicating additional GK Orgs

3 participants