Prevents cloud integration sync process from opening gkdev connect page/flow #3612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3608
From the "sync cloud integrations" process we were setting "create if needed", which in
fetchOrCreateSession
will cause the gkdev connect flow to start (and website to open) if the session could not be fetched from the cloud.This causes undesirable/unexpected UX for users, especially because it can happen from the background sync for cloud integrations, and can occur daily on each check-in.
In the case of #3608, the user had no local gitlab session, one existed in the cloud, but it was expired and could not be refreshed, causing the prompt to happen regularly on vscode launch or profile change.
This change adds a new
sync
flag to theensureSession
/getSession
auth flow that acts as a softer version ofcreateIfNeeded
, and will not trigger aconnectCloudIntegration
call infetchOrCreateSession
ofCloudIntegrationAuthenticationProvider
ifsession
was returned asundefined
fromfetchSession
, either due to an error or because it didn't exist, sincesync
, unlikecreateIfNeeded
, does not satisfy theshouldCreateSession
check.