Skip to content

Conversation

axosoft-ramint
Copy link
Contributor

Utility functions for debugging purposes only.

Also included in this PR are some fixes to types in the license response of check-in, since all license keys are not guaranteed to be in the response.

@axosoft-ramint axosoft-ramint added the area-pro-account Issues or features related to Pro accounts label Sep 27, 2024
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment on lines 34 to 37
if (isDebugging) {
expiresOn = createFromDateDelta(expiresOn, { minutes: 1 });
days = 0;
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably nuke this now and the "reset" command too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Going to go ahead and remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's keep the "reset" command for subscription because it wipes the stored subscription, which is something these debug utils don't mess with. So it feels like it still has separate utility. Removing this special case date logic for preview trials seems fine though.

@axosoft-ramint axosoft-ramint merged commit e3795f8 into main Sep 28, 2024
3 checks passed
@axosoft-ramint axosoft-ramint deleted the feature/mock-licenses-for-debug branch September 28, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-pro-account Issues or features related to Pro accounts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants