Skip to content

Pass alphanumeric property to autolink #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2024
Merged

Pass alphanumeric property to autolink #3631

merged 2 commits into from
Sep 30, 2024

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Sep 29, 2024 •
edited
Loading

Description

image

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Sep 29, 2024 that may be closed by this pull request
Auto-links not working for alphanumberic issue numbers #3617
Closed
@nzaytsev nzaytsev requested a review from eamodio September 29, 2024 09:04
@eamodio
Refactors autolinks configuration
5df73dc 
 - Updates autolink interfaces for better type safety
 - Enhances autolink configuration with explicit boolean flags
 - Adjusts remote providers to use updated autolink structure
eamodio
eamodio approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I expanded the changes a bit more to include the ignoreCase flag and align the types to avoid issues in the future.

@eamodio eamodio merged commit cc933ca into main Sep 30, 2024
3 checks passed
@eamodio eamodio deleted the bugs/3617-auto-links-not-working-for-alphanumberic-issue-numbers branch October 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio eamodio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-links not working for alphanumberic issue numbers

2 participants

@nzaytsev @eamodio