Attempts to pre-open PR branch when using Switch or Open in Worktree #3635
+30
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axosoft-ramint
added
area-launchpad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3627
Leverages
getOrOpenPullRequestRepositoryto try to pre-identify the PR's repo, which then skips the "repo match" step in the deep link flow.Note: this has undesirable effects with virtual repos, so I added a
skipVirtualopen to skip opening virtual uris for now. A bigger refactor of target opening logic (moving it out of the deep link service into its own service) will probably include better virtual repo support in the flow, but for now it doesn't work for most cases ofOpen in Worktree.