Fixes home view bugs #3730
Merged
Fixes home view bugs #3730
+101
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzaytsev
requested review from
axosoft-ramint,
d13 and
eamodio
and removed request for
axosoft-ramint and
d13
nzaytsev
force-pushed
the
bugs/home-view
branch
from
0edc19a to
305ea9b
Compare
d13
reviewed
Nov 12, 2024
| ${when(overview.choices, () => html`<gl-change-repo .options=${overview.choices}></gl-change-repo>`)} | ||
| </h3> | ||
| ${activeBranches.map(branch => this.renderRepoBranchCard(overview!.repository.name, branch))} | ||
| ${repeat(activeBranches, branch => this.renderRepoBranchCard(overview.repository.name, branch))} |
There was a problem hiding this comment.
repeat isn't really beneficial without adding a keyFn
Suggested change
| ${repeat(activeBranches, branch => this.renderRepoBranchCard(overview.repository.name, branch))} | |
| ${repeat(activeBranches, branch => branch.name, branch => this.renderRepoBranchCard(overview.repository.name, branch))} |
There was a problem hiding this comment.
ok, reverted it to reduce the changes. I believe it doesn't make sense on small-size lists
| ></gl-button> | ||
| <gl-button appearance="secondary" density="compact" tooltip=${forcePushTooltip} | ||
| <gl-button | ||
| href=${createWebviewCommandLink('gitlens.views.home.push', 'gitlens.views.home', '', { |
nzaytsev
force-pushed
the
bugs/home-view
branch
from
305ea9b to
9feaba1
Compare
- handle push/pull actions - add link to pr - control force branches reloading
nzaytsev
force-pushed
the
bugs/home-view
branch
from
9feaba1 to
046a6a2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses