Skip to content

Adds no branches placeholder to keep the date filter always displayed #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2024
Merged

Adds no branches placeholder to keep the date filter always displayed #3756

merged 3 commits into from
Nov 15, 2024

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Nov 15, 2024 •
edited
Loading

Description

Screen.Recording.2024-11-15.at.10.44.07.mov

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Nov 15, 2024 that may be closed by this pull request
Date filter is disappeared if no items matched the filter #3755
Closed
@nzaytsev nzaytsev requested a review from d13 November 15, 2024 03:43
d13
d13 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - made a couple tweaks

@d13 d13 merged commit e8d51de into main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Date filter is disappeared if no items matched the filter

2 participants

@nzaytsev @d13