-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Shows different "globe" tooltips on GitHub and Jira issues in StartWork #3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows different "globe" tooltips on GitHub and Jira issues in StartWork #3775
Conversation
4617445
to
be89554
Compare
be89554
to
6c5bad9
Compare
6c5bad9
to
471eb0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny, very quick suggestions. Works in testing, so I think once these are addressed we're good to merge it.
src/plus/startWork/startWork.ts
Outdated
if (!isStateWithType(state)) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably throw here and possibly include a debugger
line if we don't have a type
by this point, because something must have gone very wrong. Maybe we can use a function similar to assertsLaunchpadStepState
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axosoft-ramint fixed
src/plus/startWork/startWork.ts
Outdated
return md5(item.item.issue.id); | ||
} | ||
|
||
function buildItemActionTelemetryData(item: StartWorkItem) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: this is used outside of "action" contexts, and the action
property is really only being set in sendItemActionTelemetry
, so maybe we just call this buildItemTelemetryData
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
471eb0e
to
5724a60
Compare
Closes #3774
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses