Skip to content

Shows different "globe" tooltips on GitHub and Jira issues in StartWork #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2024
Merged

Shows different "globe" tooltips on GitHub and Jira issues in StartWork #3775

merged 4 commits into from
Nov 21, 2024

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 18, 2024 •
edited
Loading

Closes #3774

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb pushed a commit that referenced this pull request Nov 18, 2024
@chivorotkiv
Shows different "globe" tooltips on GitHub and Jira issues in StartWork
49a96c6 
(#3774, #3775)
sergeibbb pushed a commit that referenced this pull request Nov 18, 2024
@chivorotkiv
Sends telemetry event when an issue is opened in web browser
be89554 
(#3774, #3775)
@sergeibbb sergeibbb force-pushed the 3774-start-work-show-different-globe-tooltips branch from 4617445 to be89554 Compare November 18, 2024 18:24
sergeibbb pushed a commit that referenced this pull request Nov 19, 2024
@chivorotkiv @sergeibbb
Shows different "globe" tooltips on GitHub and Jira issues in StartWork
87aa96b 
(#3774, #3775)
sergeibbb pushed a commit that referenced this pull request Nov 19, 2024
@chivorotkiv @sergeibbb
Sends telemetry event when an issue is opened in web browser
6c5bad9 
(#3774, #3775)
@sergeibbb sergeibbb force-pushed the 3774-start-work-show-different-globe-tooltips branch from be89554 to 6c5bad9 Compare November 19, 2024 11:57
axosoft-ramint
axosoft-ramint reviewed Nov 19, 2024
View reviewed changes
sergeibbb pushed a commit that referenced this pull request Nov 20, 2024
@chivorotkiv @sergeibbb
Shows different "globe" tooltips on GitHub and Jira issues in StartWork
29804f5 
(#3774, #3775)
sergeibbb added a commit that referenced this pull request Nov 20, 2024
@sergeibbb
Sends telemetry event when an issue is opened in web browser
6c0fcb6 
(#3774, #3775)
sergeibbb added a commit that referenced this pull request Nov 20, 2024
@sergeibbb
Reuses a function that prepares issue data for telemetry
03ce3d4 
(#3774, #3775)
sergeibbb added a commit that referenced this pull request Nov 20, 2024
@sergeibbb
Adds required type to 'startWork/issue/action' telemetry event
471eb0e 
(#3774, #3775)
@sergeibbb sergeibbb force-pushed the 3774-start-work-show-different-globe-tooltips branch from 6c5bad9 to 471eb0e Compare November 20, 2024 14:21
axosoft-ramint
axosoft-ramint reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny, very quick suggestions. Works in testing, so I think once these are addressed we're good to merge it.

src/plus/startWork/startWork.ts Outdated
Comment on lines 175 to 177
if (!isStateWithType(state)) {
continue;
}
Copy link
Contributor

@axosoft-ramint axosoft-ramint Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably throw here and possibly include a debugger line if we don't have a type by this point, because something must have gone very wrong. Maybe we can use a function similar to assertsLaunchpadStepState?

Copy link
Member Author

@sergeibbb sergeibbb Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it just fighting the type-system. Because even if I assign state.type right before the function call it does not recognize the type:

image

But at the same time this works well:

const type: string = state.type
image

Copy link
Member Author

@sergeibbb sergeibbb Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axosoft-ramint fixed

src/plus/startWork/startWork.ts Outdated
return md5(item.item.issue.id);
}

function buildItemActionTelemetryData(item: StartWorkItem) {
Copy link
Contributor

@axosoft-ramint axosoft-ramint Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: this is used outside of "action" contexts, and the action property is really only being set in sendItemActionTelemetry, so maybe we just call this buildItemTelemetryData?

Copy link
Member Author

@sergeibbb sergeibbb Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sergeibbb sergeibbb force-pushed the 3774-start-work-show-different-globe-tooltips branch from 471eb0e to 5724a60 Compare November 21, 2024 13:26
@sergeibbb sergeibbb merged commit e72be11 into main Nov 21, 2024
3 checks passed
sergeibbb pushed a commit that referenced this pull request Nov 21, 2024
@chivorotkiv @sergeibbb
Shows different "globe" tooltips on GitHub and Jira issues in StartWork
c778a86 
(#3774, #3775)
sergeibbb added a commit that referenced this pull request Nov 21, 2024
@sergeibbb
Sends telemetry event when an issue is opened in web browser
9ee3138 
(#3774, #3775)
sergeibbb added a commit that referenced this pull request Nov 21, 2024
@sergeibbb
Reuses a function that prepares issue data for telemetry
d40c73a 
(#3774, #3775)
@sergeibbb sergeibbb deleted the 3774-start-work-show-different-globe-tooltips branch November 21, 2024 13:29
d13 pushed a commit that referenced this pull request Nov 21, 2024
@chivorotkiv @d13
Shows different "globe" tooltips on GitHub and Jira issues in StartWork
30aa765 
(#3774, #3775)
d13 pushed a commit that referenced this pull request Nov 21, 2024
@sergeibbb @d13
Sends telemetry event when an issue is opened in web browser
9b39f84 
(#3774, #3775)
d13 pushed a commit that referenced this pull request Nov 21, 2024
@sergeibbb @d13
Reuses a function that prepares issue data for telemetry
7319339 
(#3774, #3775)
d13 pushed a commit that referenced this pull request Nov 21, 2024
@sergeibbb @d13
Adds required type to 'startWork/issue/action' telemetry event
3ef17ae 
(#3774, #3775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axosoft-ramint axosoft-ramint axosoft-ramint left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Start Work: show different "globe" tooltips on GitHub and Jira issues

4 participants

@sergeibbb @axosoft-ramint @chivorotkiv