Adds stashes into Commit view #3797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated 1 suggestion.
Files not reviewed (8)
- package.json: Language not supported
- src/views/branchesView.ts: Evaluated as low risk
- src/views/commitsView.ts: Evaluated as low risk
- src/views/nodes/branchNode.ts: Evaluated as low risk
- src/views/nodes/repositoryNode.ts: Evaluated as low risk
- src/git/gitProviderService.ts: Evaluated as low risk
- src/views/nodes/remoteNode.ts: Evaluated as low risk
- src/views/nodes/branchesNode.ts: Evaluated as low risk
| const data = await this.git.log( | ||
| repoPath, | ||
| { configs: gitLogDefaultConfigsWithFiles, ref: options?.ref, stdin: options?.stdin }, | ||
| { configs: gitLogDefaultConfigsWithFiles, ref: ref, stdin: stdin }, |
There was a problem hiding this comment.
Ensure that the 'stdin' variable is only included when it has valid content to avoid unexpected behavior. Suggestion: { configs: gitLogDefaultConfigsWithFiles, ref: ref, ...(stdin ? { stdin } : {}) }
Suggested change
| { configs: gitLogDefaultConfigsWithFiles, ref: ref, stdin: stdin }, | |
| { configs: gitLogDefaultConfigsWithFiles, ref: ref, ...(stdin ? { stdin } : {}) } |
Copilot uses AI. Check for mistakes.
eamodio
force-pushed
the
feature/commits-show-stashes
branch
2 times, most recently
from
34cd987 to
103d555
Compare
eamodio
changed the title
eamodio
force-pushed
the
feature/commits-show-stashes
branch
from
103d555 to
ec140cb
Compare
|
The settings are all off by default, because there could be perf implications for large repos. So the risks here are super low. |
axosoft-ramint
approved these changes
Dec 5, 2024
eamodio
force-pushed
the
feature/commits-show-stashes
branch
from
ec140cb to
0a95e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready for review/testing, as it works for any views that use "branch nodes", e.g. Commits, Branches, Worktrees, Repositories views.
We will need to figure out how to get it to work with the Commit Graph without having to refresh all the commits (and stashes) based on the selected "Branches Visibility"@axosoft-ramint maybe instead of filtering the stash commits, we just also return a set of "reachable" commits, and then be able to pass both sets into the Graph or something.We will need to handle the Commit Graph differently.