Improves Start Work flows #3843
Merged
+350
−343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
approved these changes
Dec 6, 2024
| step: 'accelerate-pr-reviews', | ||
| source: 'launchpad', | ||
| detail: 'info', | ||
| const hasConnectedIntegration = some(context.connectedIntegrations.values(), c => c); |
There was a problem hiding this comment.
Probably should filter to the supported integrations for Launchpad
There was a problem hiding this comment.
context.connectedIntegrations is already filtered to supported Launchpad integrations where it is set up. See getConnectedIntegrations of LaunchpadProvider
axosoft-ramint
force-pushed
the
debt/start-work-and-launchpad-integration-flows
branch
from
656f4bf to
01bd71f
Compare
- Adds title button to connect additional integrations. - Adds telemetry event startWork/title/action - Separates out "create branch" logic from Start Work and moves into its own telemetry even home/createBranch - Removes all references to "start work type" including in telemetry - Updates placeholder messaging - Adds option to connect additional integrations or manage integrations when no issues are found. - Adds telemetry event startWork/action - Fixes back button and prevents refetching issues when clicked - Updates freeze/resume logic into shared place and applies to all areas that use it - Removes launchpad description item when at least one integration is connected in the connect step # Conflicts: # src/constants.telemetry.ts Removes todo on comment and sets up similar event for startWork
axosoft-ramint
force-pushed
the
debt/start-work-and-launchpad-integration-flows
branch
from
01bd71f to
3dc37d4
Compare
axosoft-ramint
deleted the
debt/start-work-and-launchpad-integration-flows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3832
Closes #3833
Closes #3836