Restores optimistic behavior for Launchpad pin/snooze #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axosoft-ramint
force-pushed
the
3791-pinsnooze-in-launchpad-trigger-a-full-refresh-and-are-no-longer-optimistic
branch
from
0771847 to
e449479
Compare
axosoft-ramint
deleted the
3791-pinsnooze-in-launchpad-trigger-a-full-refresh-and-are-no-longer-optimistic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3791
At some point along the way, we seem to have changed the "update items" logic in Launchpad to always force a full refresh of everything. For actions like pin, snooze, open on provider, merge, etc. we already have the provider bust the relevant cache so that only items that have changed are refreshed. So I changed the default behavior to use caches and only in a few places now do we force the full refresh.
Furthermore, to make pin/snooze/unpin/unsnooze even more optimistic, I created an
optimisticallyUpdateItemsfunction that just refreshes the list without having to do all the rest of the work.These actions should be much more responsive now.