Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vscodeignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
.yarn/**
docs/**
emoji/**
images/docs/sponsors/**
images/docs/gitlens-preview.gif
images/docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't exclude all the docs images, because any images referenced in the README (which is the extension manifest page), walkthroughs, etc, need to be available locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any images referenced in the README

They are referenced to raw.githubusercontent.com, for example:

<a title="Watch the GitLens Getting Started video" href="https://www.youtube.com/watch?v=UQPb73Zz9qk"><img src="https://raw.githubusercontent.com/gitkraken/vscode-gitlens/main/images/docs/get-started-video.png" alt="Watch the GitLens Getting Started video" /></a>

If I open readme, I see that it's referenced to cloud storage, not to locally bundled images

Screenshot 2024-12-18 at 10 27 12

There is no place where the image from this dir is used locally

walkthroughs, etc

walkthroughs assets are placed in another directory, I didn't touch it. But it can also be moved to cloud storage and removed from the bundle

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah -- I forgot that the VS Code marketplace changed to require all README links to be https. So it looks like you are correct those images don't need to be bundled.

As for the walkthroughs, if we use https links then the walkthroughs won't work offline, which is not ideal. So we should leave them alone.

images/icons/**
images/originals/**
node_modules/**
Expand Down Expand Up @@ -46,3 +45,4 @@ tsconfig*.json
tsconfig*.tsbuildinfo
webpack.config*.mjs
yarn.lock
.wdio-vscode-service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't hurt anything, but this already isn't getting bundled today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this already isn't getting bundled today

I see that this folder is not git ignored, and I see it in the bundled zip
Screenshot 2024-12-18 at 10 22 00

This doesn't hurt anything

Maybe it's truth in the environment that is isolated from tests running, but I see that it may affect the final size

Screenshot 2024-12-18 at 10 23 12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is creating that folder -- we aren't using webdriver, is that just an old folder you have? When I said it won't be bundled, I meant via CI (your local folder can have all kinds of stuff that would get "accidentally" bundled)

Binary file removed images/docs/code-lens.png
Binary file not shown.
Binary file removed images/docs/commit-details-view.png
Binary file not shown.
Binary file removed images/docs/gitlens-logo-anybg.png
Binary file not shown.
Binary file removed images/docs/gitlens-logo-dark.png
Binary file not shown.
Binary file removed images/docs/gitlens-logo.png
Binary file not shown.
Binary file removed images/docs/gitlens-preview.gif
Binary file not shown.
Binary file removed images/docs/gutter-toggle.png
Binary file not shown.
Binary file removed images/docs/hosting-integrations.png
Binary file not shown.
Binary file removed images/docs/hovers-annotations-changes.png
Binary file not shown.
Binary file removed images/docs/hovers-annotations-details.png
Binary file not shown.
Binary file removed images/docs/hovers-annotations.png
Binary file not shown.
Binary file removed images/docs/hovers-current-line-changes.png
Binary file not shown.
Binary file removed images/docs/line-history-view.png
Binary file not shown.
Binary file removed images/docs/menu-branch-history.png
Binary file not shown.
Binary file removed images/docs/menu-commit-details.png
Binary file not shown.
Binary file removed images/docs/menu-commit-file-details.png
Binary file not shown.
Binary file removed images/docs/menu-commit-search.png
Binary file not shown.
Binary file removed images/docs/menu-file-history.png
Binary file not shown.
Binary file removed images/docs/menu-repo-status.png
Binary file not shown.
Binary file removed images/docs/menu-stash-details.png
Binary file not shown.
Binary file removed images/docs/menu-stash-list.png
Binary file not shown.
Binary file removed images/docs/menus-example.png
Binary file not shown.
Binary file removed images/docs/menus.png
Binary file not shown.
Binary file removed images/docs/repositories-view.png
Binary file not shown.
Binary file removed images/docs/settings.png
Binary file not shown.
Binary file removed images/snowman.png
Diff not rendered.
8 changes: 0 additions & 8 deletions src/webviews/apps/settings/settings.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@
data-placement="#{placement}"
data-vscode-context='{ "webview": "#{webviewId}", "webviewInstance": "#{webviewInstanceId}" }'
>
<!-- <canvas class="snow"></canvas>
<img
class="snow__trigger snow__trigger--fixed-right snow__trigger--flipped"
title="Let it snow — Happy Holidays!"
alt="Let it snow — Happy Holidays!"
src="#{root}/images/snowman.png"
/> -->

<div class="container">
<header>
<h1 class="brand"><gitlens-logo></gitlens-logo> <small>Git Supercharged</small></h1>
Expand Down
Loading