-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Reduces VSIX size ignoring docs media #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,7 @@ | |
.yarn/** | ||
docs/** | ||
emoji/** | ||
images/docs/sponsors/** | ||
images/docs/gitlens-preview.gif | ||
images/docs | ||
images/icons/** | ||
images/originals/** | ||
node_modules/** | ||
|
@@ -46,3 +45,4 @@ tsconfig*.json | |
tsconfig*.tsbuildinfo | ||
webpack.config*.mjs | ||
yarn.lock | ||
.wdio-vscode-service | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't hurt anything, but this already isn't getting bundled today. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what is creating that folder -- we aren't using webdriver, is that just an old folder you have? When I said it won't be bundled, I meant via CI (your local folder can have all kinds of stuff that would get "accidentally" bundled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't exclude all the docs images, because any images referenced in the README (which is the extension manifest page), walkthroughs, etc, need to be available locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are referenced to raw.githubusercontent.com, for example:
vscode-gitlens/README.md
Line 14 in 0f6f6ac
If I open readme, I see that it's referenced to cloud storage, not to locally bundled images
There is no place where the image from this dir is used locally
walkthroughs assets are placed in another directory, I didn't touch it. But it can also be moved to cloud storage and removed from the bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah -- I forgot that the VS Code marketplace changed to require all README links to be
https
. So it looks like you are correct those images don't need to be bundled.As for the walkthroughs, if we use
https
links then the walkthroughs won't work offline, which is not ideal. So we should leave them alone.