Adds a new control for graph branches visibility #3929
Conversation
nzaytsev
force-pushed
the
feature/3101-unhide-branches-dropdown
branch
from
8d456cd to
0549b9f
Compare
|
Based on what I can see in the video, this seems like a good improvement over existing functionality. @axosoft-ramint @d13 Is there any reason this shouldn't go into 16.2? |
There was a problem hiding this comment.
Without updating the component, the "hidden branches" UX is now in two places - in our toolbar and in the branch/tag header. I haven't checked, but if the in-header one is not implemented in the component, perhaps we could remove it. If it is in the component, we would probably want a way to disable it.
Neither of that needs to block this from merging though - just debt.
I do have some tiny nitpicks about the code itself which can be addressed before merging - see below.
|
Thanks @axosoft-ramint ! @nzaytsev if you can address Ramin's concerns here, then we can get this into the 16.2 release. |
| function getRemoteIcon(type: string | number) { | ||
| switch (type) { | ||
| case 'head': | ||
| return 'vm'; | ||
| case 'remote': | ||
| return 'cloud'; | ||
| case 'tag': | ||
| return 'tag'; | ||
| default: | ||
| return ''; | ||
| } | ||
| } |
There was a problem hiding this comment.
We should be using the remote's avatar icon for a remote branch in this list if the avatars are enabled in the graph's settings. Always using a generic cloud icon feels like a regression
|
@nzaytsev Updated the branch with most of the labeling changes. We can do the remote icons in an update post-release, |
3 participants
Description
The additional dropdown is appeared only when not there are some branches hidden. It blinks twice after the first branch hiding, then it blinks one time per hidden branch. The dropdown is closed when the list is ended
Screen.Recording.2025-01-15.at.15.38.09.mov
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses