Skip to content

Prevents caching a Cloud GitHub Enterprise integration without domain #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Prevents caching a Cloud GitHub Enterprise integration without domain #3933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/plus/integrations/integrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,17 +479,19 @@ export class IntegrationService implements Disposable {
SelfHostedIntegrationId.CloudGitHubEnterprise,
);
if (existingConfigured?.length) {
const { domain } = existingConfigured[0];
if (domain == null) throw new Error(`Domain is required for '${id}' integration`);
const { domain: configuredDomain } = existingConfigured[0];
if (configuredDomain == null) throw new Error(`Domain is required for '${id}' integration`);
integration = new (
await import(/* webpackChunkName: "integrations" */ './providers/github')
).GitHubEnterpriseIntegration(
this.container,
this.authenticationService,
this.getProvidersApi.bind(this),
domain,
configuredDomain,
id,
);
// assign domain because it's part of caching key:
domain = configuredDomain;
break;
}

Expand Down
Loading