Skip to content

Conversation

nzaytsev
Copy link
Contributor

Description

Wanted to provide webviewId as context (and implemented, but then reverted), but the command registration on graphWebview side is a bit incorrect, it always handles events of gitlens.views.graph

So, I provide webviewId from graphWrapper and check inside the MergeConflictWarning, then pick between createWebviewCommandLink and createCommandLink. It's bad that there are several types for commands and webviewIds, it's not easy to unify it now

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Jan 20, 2025 that may be closed by this pull request
@nzaytsev nzaytsev requested review from d13 and eamodio January 20, 2025 04:32
@d13
Copy link
Member

d13 commented Jan 20, 2025

Resolved with 4f0d3d7

@d13 d13 closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph breaks when opening in an editor tab

2 participants