Skip to content

Conversation

@axosoft-ramint
Copy link
Contributor

@axosoft-ramint axosoft-ramint commented Jan 25, 2025

Major refactor (and fix to Home View integration states) that does the following:

  • Creates a new configuredIntegrationService
  • Moves all management of stored integration configurations as well as stored integration authentication sessions to the new service
  • Renames functions across auth providers and the new service to be clearer, and simplifies logic on the integration authentication providers where possible
  • Adds domain property to integration auth sessions
  • Removes redundant code that isn't used, and makes a session descriptor required when interacting with an auth provider
  • Updates home view to use the new service to get configured integrations

We will want this in before adding other cloud integrations into the mix, like Azure.

@axosoft-ramint axosoft-ramint added area-integrations Issues or features related to integrations debt Technical debt labels Jan 25, 2025

if (!session) return undefined;

// TODO: Once we care about domains, we should try to match the domain here against ours, and if it fails, return undefined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axosoft-ramint

quick question. Which domains are "ours"? those that are stored in configuredIntegrationService?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ours" are the ones we have locally stored and configured, as you guessed. While the other domain being compared here is the one returned by our api for the provider.

Updates Home view to use new service for configured integrations
@axosoft-ramint axosoft-ramint force-pushed the debt/configured-integrations branch from 5f05d75 to 15a2c4c Compare January 27, 2025 16:51
@axosoft-ramint axosoft-ramint merged commit d1f6477 into main Jan 27, 2025
3 checks passed
@axosoft-ramint axosoft-ramint deleted the debt/configured-integrations branch January 27, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues or features related to integrations debt Technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants