4039 Launchpad view can cause an unwanted "add remote" prompt on load #4081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamodio
reviewed
Feb 21, 2025
src/views/viewCommands.ts
Outdated
| if (identity.remote?.url == null) return; | ||
| await repo.git | ||
| .remotes() | ||
| .addRemoteWithResult?.(identity.provider.repoDomain, identity.remote.url, { fetch: true }); |
There was a problem hiding this comment.
Suggested change
| .addRemoteWithResult?.(identity.provider.repoDomain, identity.remote.url, { fetch: true }); | |
| .addRemote?.(identity.provider.repoDomain, identity.remote.url, { fetch: true }); |
Since we aren't returning the remote we don't need to wait for it
eamodio
approved these changes
Feb 22, 2025
axosoft-ramint
deleted the
4039-launchpad-view-can-cause-an-unwanted-add-remote-prompt-on-load
branch
saeedzaha
pushed a commit
to saeedzaha/vscode-gitlens
that referenced
this pull request
Apr 28, 2025
…gitkraken#4081) * Fixes remote and open branch matching on base ref * Uses command message node instead of prompt for missing remote * Updates view styling --------- Co-authored-by: Eric Amodio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4039
Two fixes, each one commit: