Skip to content

Removes SearchedIssue and SearchedPullRequest wrappers #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Removes SearchedIssue and SearchedPullRequest wrappers #4102

merged 1 commit into from
Feb 26, 2025

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Feb 25, 2025 •
edited
Loading

Removes SearchedIssue and SearchedPullRequest wrappers because reasons are not used anymore (#4098)

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Feb 25, 2025 that may be closed by this pull request
Use of SearchedIssue and SearchedPullRequest is no longer neccesary #4098
Closed
3 tasks
@sergeibbb sergeibbb force-pushed the debt/4098-remove-searched-wrappers branch from 78da759 to 3cb128e Compare February 25, 2025 13:42
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Removes SearchedIssue and SearchedPullRequest wrappers,
44b12c7 
because reasons are not used anymore (#4098, #4102)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Fixes formatting to satisfy prettier
316b018 
(#4102)
@sergeibbb sergeibbb force-pushed the debt/4098-remove-searched-wrappers branch from 3cb128e to 316b018 Compare February 25, 2025 13:46
axosoft-ramint
axosoft-ramint approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a scan., LGTM.

Lots of touched areas to test here - would be easier in the pre-release.

eamodio
eamodio reviewed Feb 25, 2025
View reviewed changes
src/plus/integrations/providers/models.ts Outdated
filterUsed?: IssueFilter,
userLogin?: string,
): SearchedIssue | undefined {
export function toSearchedIssue(issue: ProviderIssue, provider: ProviderReference): IssueShape | undefined {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably to rename to something like:

Suggested change
export function toSearchedIssue(issue: ProviderIssue, provider: ProviderReference): IssueShape | undefined {
export function toIssueShape(issue: ProviderIssue, provider: ProviderReference): IssueShape | undefined {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

eamodio
eamodio approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too -- 1 minor nit

sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Removes SearchedIssue and SearchedPullRequest wrappers,
39133d6 
because reasons are not used anymore (#4098, #4102)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Fixes formatting to satisfy prettier
867f9d2 
(#4102)
@sergeibbb sergeibbb force-pushed the debt/4098-remove-searched-wrappers branch from 316b018 to 867f9d2 Compare February 26, 2025 08:21
@sergeibbb sergeibbb force-pushed the debt/4098-remove-searched-wrappers branch from 867f9d2 to 36cc563 Compare February 26, 2025 08:24
@sergeibbb sergeibbb added the needs-verification Request for verification label Feb 26, 2025
@sergeibbb
Copy link
Member Author

sergeibbb commented Feb 26, 2025 •
edited
Loading

@axosoft-ramint

Lots of touched areas to test here - would be easier in the pre-release.

I've added testing notes to #4098

@sergeibbb sergeibbb merged commit 56a5fa2 into main Feb 26, 2025
3 checks passed
@sergeibbb sergeibbb deleted the debt/4098-remove-searched-wrappers branch February 26, 2025 08:42
@sergeibbb sergeibbb removed the needs-verification Request for verification label Feb 26, 2025
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Removes SearchedIssue and SearchedPullRequest wrappers,
dd121b8 
because reasons are not used anymore (gitkraken#4098, gitkraken#4102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamodio eamodio eamodio approved these changes

@axosoft-ramint axosoft-ramint axosoft-ramint approved these changes

@d13 d13 Awaiting requested review from d13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use of SearchedIssue and SearchedPullRequest is no longer neccesary

3 participants

@sergeibbb @eamodio @axosoft-ramint