Fixes isMaybeConnected to let it return undefined when the value is unknown

[sergeibbb]

Description

The problem

I've noticed that here the connected variable is always boolean and can never be equal to null, so we always skip the if body here:

vscode-gitlens/src/git/gitProviderService.ts

Lines 1143 to 1149 in fef314b

	let connected = remote.maybeIntegrationConnected;
	// If we don't know if we are connected, only check if the remote is the default or there is only one
	// TODO@eamodio is the above still a valid requirement?
	if (connected == null && (remote.default || remotes.length === 1)) {
	const integration = await remote.getIntegration();
	connected = await integration?.isConnected();
	}

Therefore, integrations with unknown connection status never get saved here:

vscode-gitlens/src/git/gitProviderService.ts

Lines 1191 to 1194 in fef314b

	setContext(
	'gitlens:repos:withHostingIntegrationsConnected',
	reposWithHostingIntegrationsConnected.size ? [...reposWithHostingIntegrationsConnected] : undefined,
	),

As a result we don't see them on reading. For example in the List of Remotes it didn't see a connected Bitbucket integration and didn't request for PRs:

vscode-gitlens/src/views/nodes/branchNode.ts

Lines 178 to 184 in fef314b

	let prPromise: Promise<PullRequest | undefined> | undefined;
	if (
	this.view.config.pullRequests.enabled &&
	this.view.config.pullRequests.showForBranches &&
	(branch.upstream != null || branch.remote) &&
	getContext('gitlens:repos:withHostingIntegrationsConnected')?.includes(branch.repoPath)
	) {

Investigation

I've noticed that the related code only changed once and the "always boolean effect" might appear occasionally.

Suggested solution

I suggest we should let it be undefined again.

Checklist

• I have followed the guidelines in the Contributing document
• My changes follow the coding style of this project
• My changes build without any errors or warnings
• My changes have been formatted and linted
• My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
• My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
• My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

[eamodio]

Good catch!