Skip to content

Bitbucket Data Center cloud integration #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 25, 2025
Merged

Bitbucket Data Center cloud integration #4146

merged 11 commits into from
Mar 25, 2025

Conversation

@sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Mar 12, 2025 •
edited
Loading

Description

solves #4107

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Mar 12, 2025 that may be closed by this pull request
Bitbucket Server #4107
Closed
2 tasks
sergeibbb added a commit that referenced this pull request Mar 12, 2025
@sergeibbb
Merge BitbucketServer PRs from the Launchpad
a50156d 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Merge BitbucketServer PRs from the Launchpad
a1dc12f 
(#4107, #4146)
@sergeibbb sergeibbb force-pushed the 4107-bitbucket-server branch 2 times, most recently from a1dc12f to ccdc77f Compare March 13, 2025 13:44
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Merge BitbucketServer PRs from the Launchpad
ccdc77f 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows null avatars as an account icon
4e71b03 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Connects BitbucketServer cloud integration displays among connected i…
8f4bb50 
…ntegrations on the Home View

(#4107, #4146)
@sergeibbb sergeibbb force-pushed the 4107-bitbucket-server branch from 4e71b03 to aa24560 Compare March 13, 2025 14:21
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows connected bitbucket-server integration on remotes
ad83d55 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows branch PRs on remote
0378787 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows enriched PRs on hover
9681624 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows BitbucketServer PR on launchpad
76d44f5 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Merges BitbucketServer PRs from the Launchpad
f3e6cfa 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Shows null avatars as an account icon
518d7d7 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Mentions BitbucketServer in the changelog
aa24560 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 13, 2025
@sergeibbb
Uses protocol that is specified on GK-cloud for Bitbucket Server
a7a792a 
(#4107, #4146)
sergeibbb
sergeibbb commented Mar 13, 2025
View reviewed changes
src/plus/integrations/providers/bitbucket-server.ts

protected get apiBaseUrl(): string {
const protocol = this._session?.protocol ?? 'https:';
return `${protocol}//${this.domain}/rest/api/1.0`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ericf-axosoft, @axosoft-ramint

URL of our test server is on HTTP, that's why I needed to make an update to gather the protocol from Cloud. These changes are here: a7a792a

@sergeibbb sergeibbb changed the base branch from main to 4128-extend-the-shared-library-to-provide-more-data-for-bitbucket-prs March 13, 2025 15:13
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Connects BitbucketServer cloud integration displays among connected i…
c08cdff 
…ntegrations on the Home View

(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Shows connected bitbucket-server integration on remotes
eaac47e 
(#4107, #4146)
@sergeibbb sergeibbb force-pushed the 4107-bitbucket-server branch from a7a792a to 1449867 Compare March 19, 2025 14:35
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Shows branch PRs on remote
2373393 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Shows enriched PRs on hover
01d6e0f 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Shows BitbucketServer PR on launchpad
4e3ce4b 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Merges BitbucketServer PRs from the Launchpad
f44fe6c 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Shows null avatars as an account icon
b27da7a 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 19, 2025
@sergeibbb
Mentions BitbucketServer in the changelog
c4b831a 
(#4107, #4146)
@sergeibbb sergeibbb force-pushed the 4107-bitbucket-server branch from cca8e86 to 6ad28b2 Compare March 25, 2025 12:39
@axosoft-ramint axosoft-ramint self-requested a review March 25, 2025 15:00
axosoft-ramint
axosoft-ramint approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@axosoft-ramint axosoft-ramint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the shared library normalizers later when they are exposed.

@sergeibbb sergeibbb merged commit 8b99b7f into main Mar 25, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Connects BitbucketServer cloud integration displays among connected i…
f4e7781 
…ntegrations on the Home View

(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Shows connected bitbucket-server integration on remotes
f72fbe0 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Shows branch PRs on remote
e4f08de 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Shows enriched PRs on hover
58cab56 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Shows BitbucketServer PR on launchpad
132c211 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Merges BitbucketServer PRs from the Launchpad
9ec6567 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Shows null avatars as an account icon
45065a7 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Mentions BitbucketServer in the changelog
70951d7 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Uses protocol that is specified on GK-cloud for Bitbucket Server
ede7d04 
(#4107, #4146)
sergeibbb added a commit that referenced this pull request Mar 25, 2025
@sergeibbb
Improves types in remoteProviders for cloudRemotesMap: makes it stricter
7b7f60e 
(#4107, #4146)
@sergeibbb sergeibbb deleted the 4107-bitbucket-server branch March 25, 2025 16:04
sergeibbb added a commit that referenced this pull request Mar 26, 2025
@sergeibbb
Handles session protocol error when session domain cannot be parsed
59bd354 
(related to #4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Connects BitbucketServer cloud integration displays among connected i…
bad2468 
…ntegrations on the Home View

(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Shows connected bitbucket-server integration on remotes
8a08b97 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Shows branch PRs on remote
05440c1 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Shows enriched PRs on hover
cbf6290 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Shows BitbucketServer PR on launchpad
8120384 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Merges BitbucketServer PRs from the Launchpad
8e8d906 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Shows null avatars as an account icon
3460832 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Mentions BitbucketServer in the changelog
071f6cb 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Uses protocol that is specified on GK-cloud for Bitbucket Server
c41e927 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Improves types in remoteProviders for cloudRemotesMap: makes it stricter
a6802c1 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Improves changelog
317b649 
(gitkraken#4107, gitkraken#4146)
saeedzaha pushed a commit to saeedzaha/vscode-gitlens that referenced this pull request Apr 28, 2025
@sergeibbb @saeedzaha
Handles session protocol error when session domain cannot be parsed
87cf039 
(related to gitkraken#4146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axosoft-ramint axosoft-ramint axosoft-ramint approved these changes

@eamodio eamodio Awaiting requested review from eamodio

@d13 d13 Awaiting requested review from d13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bitbucket Server

3 participants

@sergeibbb @d13 @axosoft-ramint