Skip to content

Make manual sync update sessions #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Make manual sync update sessions #4298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/plus/gk/subscriptionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ export class SubscriptionService implements Disposable {
return this._onDidChangeFeaturePreview.event;
}

private _onDidCheckIn = new EventEmitter<void>();
get onDidCheckIn(): Event<void> {
private _onDidCheckIn = new EventEmitter<{ force?: boolean } | void>();
get onDidCheckIn(): Event<{ force?: boolean } | void> {
return this._onDidCheckIn.event;
}

Expand Down Expand Up @@ -1067,7 +1067,7 @@ export class SubscriptionService implements Disposable {
return;
}

const validating = this.checkInAndValidateCore(session, source, options?.organizationId);
const validating = this.checkInAndValidateCore(session, source, options?.organizationId, options?.force);
if (!options?.showSlowProgress) return validating;

// Show progress if we are waiting too long
Expand All @@ -1088,6 +1088,7 @@ export class SubscriptionService implements Disposable {
session: AuthenticationSession,
source: Source | undefined,
organizationId?: string,
force?: boolean,
): Promise<GKCheckInResponse | undefined> {
const scope = getLogScope();
this._lastValidatedDate = undefined;
Expand Down Expand Up @@ -1120,7 +1121,7 @@ export class SubscriptionService implements Disposable {
throw new AccountValidationError('Unable to validate account', undefined, rsp.status, rsp.statusText);
}

this._onDidCheckIn.fire();
this._onDidCheckIn.fire({ force: force });

const data: GKCheckInResponse = await rsp.json();
this._getCheckInData = () => Promise.resolve(data);
Expand Down
4 changes: 2 additions & 2 deletions src/plus/integrations/integrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ export class IntegrationService implements Disposable {
}
}

private onUserCheckedIn() {
void this.syncCloudIntegrations(false);
private onUserCheckedIn(options?: { force?: boolean } | void) {
void this.syncCloudIntegrations(Boolean(options?.force));
}

private onDidChangeSubscription(e: SubscriptionChangeEvent) {
Expand Down